close
Skip to content

chore: use release-keys keyring for gpg fingerprints #2459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nschonni wants to merge 1 commit into from
Closed

chore: use release-keys keyring for gpg fingerprints #2459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
chore: use release-keys keyring for gpg fingerprints
  • Loading branch information
@nschonni
nschonni committed Apr 14, 2026
commit d427a82c39f4aeab87821e63fb13f61f7d360fde
8 changes: 0 additions & 8 deletions keys/node.keys
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions update-keys.sh
View file
Open in desktop

This file was deleted.

7 changes: 6 additions & 1 deletion update.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,11 @@ fi
# TODO: Should be able to specify target architecture manually
arch=$(get_arch)

# Grab and parse fingerprints for the Node.js Releasers
curl -fsSLO --compressed "https://github.com/nodejs/release-keys/raw/refs/heads/main/gpg-only-active-keys/pubring.kbx"
NODEJS_KEYS=$(gpg --no-default-keyring --keyring "./pubring.kbx" --keyid-format long --with-colons --fingerprint | awk -F: '/^pub:.*/ { getline; print $10}')
rm ./pubring.kbx

function in_versions_to_update() {
local version=$1

Expand Down Expand Up @@ -136,7 +141,7 @@ function update_node_version() {
while read -r line; do
pattern='"\$\{'$(echo "node" | tr '[:lower:]' '[:upper:]')'_KEYS\[@\]\}"'
sed -Ei -e "s/([ \\t]*)(${pattern})/\\1${line}${new_line}\\1\\2/" "${dockerfile}-tmp"
done < "keys/node.keys"
done <<< "$NODEJS_KEYS"
sed -Ei -e "/${pattern}/d" "${dockerfile}-tmp"

if is_alpine "${variant}"; then
Expand Down