close
Skip to content

chore(docs): Fix codecov link in README - #3129

Merged
YJDoc2 merged 2 commits into
youki-dev:mainfrom
khanhtc1202:patch-1
Apr 10, 2025
Merged

chore(docs): Fix codecov link in README#3129
YJDoc2 merged 2 commits into
youki-dev:mainfrom
khanhtc1202:patch-1

Conversation

@khanhtc1202

Copy link
Copy Markdown
Contributor

Description

The link to codecov on readme is old

Type of Change

  • Documentation update

Related Issues

NONE

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
@khanhtc1202 khanhtc1202 changed the title Fix codecov link in README chore(docs): Fix codecov link in README Mar 31, 2025
@YJDoc2

YJDoc2 commented Apr 1, 2025

Copy link
Copy Markdown
Collaborator

Hey @khanhtc1202 , thanks for the PR. Although I'll need to check once if this makes sense anymore, as we have disabled code-cov, so we might prefer removing the link altogether.

@utam0k

utam0k commented Apr 8, 2025

Copy link
Copy Markdown
Member

@khanhtc1202 May I ask you to remove the link in this PR?

@khanhtc1202

Copy link
Copy Markdown
Contributor Author

@utam0k Sure, let me update it 👍

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>

@YJDoc2 YJDoc2 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@YJDoc2
YJDoc2 enabled auto-merge (squash) April 9, 2025 04:31
@YJDoc2
YJDoc2 disabled auto-merge April 10, 2025 04:44
@YJDoc2
YJDoc2 enabled auto-merge (squash) April 10, 2025 04:45
@YJDoc2
YJDoc2 disabled auto-merge April 10, 2025 04:45
@YJDoc2
YJDoc2 merged commit de667c7 into youki-dev:main Apr 10, 2025
@YJDoc2

YJDoc2 commented Apr 10, 2025

Copy link
Copy Markdown
Collaborator

For note, I bypassed the ci requirements and merged as only readme changes.

@github-actions github-actions Bot mentioned this pull request Apr 10, 2025
sat0ken pushed a commit to sat0ken/youki that referenced this pull request Mar 17, 2026
* Fix codecov link in README

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>

* Remove codecov link from README

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>

---------

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants