close
Skip to content

fix Discord badge link in README#4626

Merged
leaanthony merged 2 commits into
wailsapp:masterfrom
sharkmu:master
Nov 3, 2025
Merged

fix Discord badge link in README#4626
leaanthony merged 2 commits into
wailsapp:masterfrom
sharkmu:master

Conversation

@sharkmu

@sharkmu sharkmu commented Oct 4, 2025

Copy link
Copy Markdown
Contributor

Description

Changes the Discord badge's link to a working one.

Fixes #4625

Type of change

Please select the option that is relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration using wails doctor.

I previewed the Markdown file, and it worked well. It display the amount of people online in the Discord server

  • Windows
  • macOS
  • Linux

If you checked Linux, please specify the distro and version.

Test Configuration

Please paste the output of wails doctor. If you are unable to run this command, please describe your environment in as much detail as possible.

Checklist:

  • I have updated website/src/pages/changelog.mdx with details of this PR
  • My code follows the general coding style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Summary by CodeRabbit

  • Documentation
    • Updated the Discord badge across all README translations to use a shields.io Discord badge. Affected files: English, German, Spanish, French, Japanese, Korean, Portuguese (BR), Russian, Turkish, Uzbek, and Chinese (Simplified).
    • No other content, structure, or logic changes.

@coderabbitai

coderabbitai Bot commented Oct 4, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

Updated the Discord badge image URL across README files in multiple languages to use img.shields.io (Discord badge). No other text, structure, or logic was modified.

Changes

Cohort / File(s) Summary of Changes
README Discord badge URL update
README.md, README.de.md, README.es.md, README.fr.md, README.ja.md, README.ko.md, README.pt-br.md, README.ru.md, README.tr.md, README.uz.md, README.zh-Hans.md
Replaced dcbadge.vercel.app/... Discord badge image with https://img.shields.io/discord/1042734330029547630?logo=discord. No other edits.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

I hopped through READMEs, badge to badge,
Swapped a broken carrot for a shiny tag.
Now Discord’s count gleams bright and true—
A bun-approved fix in shields of blue.
Thump-thump! The docs look neat,
Time for a celebratory lettuce treat. 🥕

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description follows the repository template with a clear summary, issue reference, type of change, testing steps, and a filled checklist, but the Test Configuration section is left blank and lacks the required wails doctor output or equivalent environment details. Please add the output of wails doctor under the Test Configuration heading or, if you were unable to run it, provide equivalent details about your environment so that reviewers can reproduce and validate your testing setup.
✅ Passed checks (4 passed)
Check name Status Explanation
Title Check ✅ Passed The title "fix Discord badge link in README" succinctly and accurately summarizes the main change of updating the Discord badge URL in the README files without unnecessary detail or noise.
Linked Issues Check ✅ Passed The pull request directly addresses issue #4625 by updating the broken Discord badge URLs across all README files to valid shields.io links, thereby restoring the display of the online user count.
Out of Scope Changes Check ✅ Passed All modifications are confined to replacing the Discord badge URL in README files and no unrelated or out-of-scope changes are present.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@leaanthony

Copy link
Copy Markdown
Member

Thanks 🙏 Please could you add an entry to the changelog located at website/src/pages/changelog.mdx?

@sonarqubecloud

sonarqubecloud Bot commented Oct 5, 2025

Copy link
Copy Markdown

@sharkmu

sharkmu commented Oct 5, 2025

Copy link
Copy Markdown
Contributor Author

Thanks 🙏 Please could you add an entry to the changelog located at website/src/pages/changelog.mdx?

Done!

@sharkmu

sharkmu commented Oct 18, 2025

Copy link
Copy Markdown
Contributor Author

@leaanthony could you take a look at it? I think it is mergeable now

@leaanthony
leaanthony merged commit 70d2d52 into wailsapp:master Nov 3, 2025
5 checks passed
@leaanthony

Copy link
Copy Markdown
Member

Thanks! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

discord badge doesn't load in README

2 participants