[darwin] Fix undo/redo#2430
Merged
Merged
Conversation
leaanthony
reviewed
Feb 28, 2023
leaanthony
left a comment
Member
There was a problem hiding this comment.
It's likely this will break in older macOS releases. I have a way to test this. I don't suppose you have a snippet you used for testing it do you? No worries if not possible 👍
Contributor
Author
Yeah also thought so, but really have no way to test this. Thanks for doing that.
I've just used a Wails vanilla project, added some text into the "greet" input box and hit |
Member
|
Wow, I'm not even sure how |
leaanthony
approved these changes
Feb 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I could only test it on the following config since I have no mac available with an older XCode or OS.
Fixes #2356