close
Skip to content

[darwin] Fix undo/redo#2430

Merged
leaanthony merged 1 commit into
masterfrom
bugfix/undo-redo-macos
Feb 28, 2023
Merged

[darwin] Fix undo/redo#2430
leaanthony merged 1 commit into
masterfrom
bugfix/undo-redo-macos

Conversation

@stffabi

@stffabi stffabi commented Feb 28, 2023

Copy link
Copy Markdown
Contributor

I could only test it on the following config since I have no mac available with an older XCode or OS.

OS           | MacOS
Version      | 13.2.1
ID           | 22D68
Xcode command line tools  | N/A          | Installed | 2396
*Xcode                    | N/A          | Installed | 14.2 (14C18)

Fixes #2356

@leaanthony leaanthony left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's likely this will break in older macOS releases. I have a way to test this. I don't suppose you have a snippet you used for testing it do you? No worries if not possible 👍

@stffabi

stffabi commented Feb 28, 2023

Copy link
Copy Markdown
Contributor Author

It's likely this will break in older macOS releases. I have a way to test this.

Yeah also thought so, but really have no way to test this. Thanks for doing that.

I don't suppose you have a snippet you used for testing it do you?

I've just used a Wails vanilla project, added some text into the "greet" input box and hit cmd-z.

@leaanthony

Copy link
Copy Markdown
Member

Wow, I'm not even sure how undo: wasn't there in the first place! undo: has been there since v10 so we're good! Thanks for this @stffabi !!!

@leaanthony
leaanthony merged commit c6146cc into master Feb 28, 2023
@leaanthony
leaanthony deleted the bugfix/undo-redo-macos branch February 28, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wails v2: undo and redo don't work in macos.

2 participants