[webview2loader] Promote go loader from experimental to stable#2199
Merged
stffabi merged 1 commit intoDec 13, 2022
Merged
Conversation
stffabi
enabled auto-merge (squash)
December 13, 2022 07:48
stffabi
force-pushed
the
feature/go-webview2-loader-default
branch
from
December 13, 2022 08:41
8ae5570 to
7fd2f6d
Compare
Default webview2loader is now the go loader
stffabi
force-pushed
the
feature/go-webview2-loader-default
branch
from
December 13, 2022 08:46
7fd2f6d to
e7a9de4
Compare
leaanthony
approved these changes
Dec 13, 2022
leaanthony
left a comment
Member
There was a problem hiding this comment.
Just a typo, otherwise LGTM
| tags = append(tags, expWebView2Loader) | ||
| message = fmt.Sprintf("An experimental Go native WebView2Loader is available. We would love to hear your feedback about it and invite you to test it by building with `-tags %s`", strings.Join(tags, ",")) | ||
| tags = append(tags, nativeWebView2Loader) | ||
| message := fmt.Sprintf("Wails is now using th new Go WebView2Loader. If you encounter any issues with it, please report them to https://github.com/wailsapp/wails/issues/2004. You could also use the old legacy loader with `-tags %s`, but keep in mind this will be deprecated in the near future.", strings.Join(tags, ",")) |
Member
|
Oh didn't notice auto merge was on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default webview2loader is now the go loader