Refactored build command#2123
Merged
Merged
Conversation
Deploying with
|
| Latest commit: |
9a74ee3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://88bbb30c.wails.pages.dev |
| Branch Preview URL: | https://feature-refactor-cli.wails.pages.dev |
stffabi
approved these changes
Nov 22, 2022
stffabi
left a comment
Contributor
There was a problem hiding this comment.
LGTM 🚀, just added a comment with a minor fix.
Co-authored-by: stffabi <stffabi@users.noreply.github.com>
leaanthony
marked this pull request as ready for review
November 24, 2022 10:30
# Conflicts: # v2/cmd/wails/internal/commands/build/build.go # v2/cmd/wails/internal/commands/dev/dev.go # v2/cmd/wails/internal/commands/generate/README.md # v2/cmd/wails/internal/commands/generate/module.go
stffabi
approved these changes
Nov 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the
buildcommand. Why do this? A number of the commands share similar flags and we have a lot of redundant code. We also have inconsistent style. By taking advantage of the latest clir release, we can tidy a lot of this code up. If the approach is agreed on, I'll move to the others.