close
Skip to content

React Hash Router Links returns 404#2050

Merged
leaanthony merged 2 commits into
wailsapp:masterfrom
marvinhosea:patch-1
Nov 17, 2022
Merged

React Hash Router Links returns 404#2050
leaanthony merged 2 commits into
wailsapp:masterfrom
marvinhosea:patch-1

Conversation

@marvinhosea

Copy link
Copy Markdown
Contributor

The linked Hash Router link is not valid anymore and returns a 404.

The linked Hash Router link is not valid anymore and returns a 404.

@misitebao misitebao left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Branch name does not conform to the rules.

@leaanthony

Copy link
Copy Markdown
Member

That's ok. I need to disable that check. It's basically useless

@leaanthony

Copy link
Copy Markdown
Member

Thanks @marvinhosea 🙏

@leaanthony
leaanthony merged commit a8bbce6 into wailsapp:master Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants