Fix binding generation special cases#1902
Merged
Merged
Conversation
Member
|
This is amazing! Thank you so much for taking the time and effort to look into this important area. It would be good to get feedback from those who opened the linked issues and see what the feedback is. Other than that, it looks great! |
Member
|
I think we can go with this. Thank you so much 🙏 |
leaanthony
approved these changes
Oct 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1901
These changes prevent
binding.GenerateModels()from yielding broken TypeScript for the following special cases:binding_nestedimport_test)[]Tormap[any]TwhereTis an imported struct don't reference the imported namespace in the generated code (e.g. we getfoo: Foo[]instead offoo: imported.Foo[])json:"foo-bar")map[T]any(whereTis anything butstring)And finally:
Extra notes:
I necromanced the binding tests from https://github.com/wailsapp/wails/tree/feature/ts-generation-tests and expanded upon them. I see that the branch has since been deleted, and the directory structure for the tests in this PR feels inelegant, so let me know if there's an obvious way to improve it and I will revise it.
As far as I can tell, the new tests cover these issues and they are resolved