close
Skip to content

Chore/react 18 create root#1489

Merged
leaanthony merged 6 commits into
wailsapp:masterfrom
tomanagle:chore/react-18-createRoot
Jun 27, 2022
Merged

Chore/react 18 create root#1489
leaanthony merged 6 commits into
wailsapp:masterfrom
tomanagle:chore/react-18-createRoot

Conversation

@tomanagle

@tomanagle tomanagle commented Jun 24, 2022

Copy link
Copy Markdown
Contributor
  • Updates the react & react-ts frontends to use createRoot instead of ReactDOM.render as ReactDOM.render is no longer supported in React 18

Docs: https://reactjs.org/blog/2022/03/08/react-18-upgrade-guide.html#updates-to-client-rendering-apis

@sidwebworks sidwebworks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 😄

@leaanthony

Copy link
Copy Markdown
Member

Thanks for doing this! Is there any chance you could add them to the directories under generate? My fear is they'll get overwritten next time we generate the templates again. It should be fairly obvious what's happening in the generate directory (those files are copied after a default vite generation) but if you need more info, I'm happy to help! 🙏

@tomanagle

Copy link
Copy Markdown
Contributor Author

Thanks for doing this! Is there any chance you could add them to the directories under generate? My fear is they'll get overwritten next time we generate the templates again. It should be fairly obvious what's happening in the generate directory (those files are copied after a default vite generation) but if you need more info, I'm happy to help! 🙏

Yup, I'll take a look around and update the PR :)

@tomanagle

Copy link
Copy Markdown
Contributor Author

I updated those templates (hopefully in the right place).

Also realised my linter was changing more lines than required, so fixed that up too

@leaanthony

Copy link
Copy Markdown
Member

Thanks for this!

@leaanthony
leaanthony merged commit d9888ce into wailsapp:master Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants