close
Skip to content

Remove solidcolour#450

Merged
dstorey merged 9 commits into
w3c:masterfrom
dstorey:remove-solidcolour
May 18, 2018
Merged

Remove solidcolour#450
dstorey merged 9 commits into
w3c:masterfrom
dstorey:remove-solidcolour

Conversation

@dstorey

@dstorey dstorey commented May 14, 2018

Copy link
Copy Markdown
Member

No description provided.

Comment thread master/pservers.html Outdated
@@ -67,8 +66,7 @@ <h2 id="Introduction">Introduction</h2>
<img
alt="Image of three types of paint servers."
src="images/pservers/pservers_example.png"/>

@dstorey dstorey May 14, 2018

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs someone to change the graphic (and alt text)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The png is based on: https://svgwg.org/svg2-draft/images/pservers/pservers_example.svg

Which is already coded in a web-compatible way (the "solid color" example is just a rect with color fill), so it's just a matter of editing out the extras & adjusting the coordinates & re-exporting the PNG. Or just delete the PNG and embed the SVG in the <img>, since it would only include well-supported SVG 1.1 features.

@AmeliaBR

Copy link
Copy Markdown
Contributor

I don't think there is any reason to update specs/color/*

It is a legacy spec, not currently used anywhere that I know of. But maybe @svgeesus would know more about that.

@AmeliaBR

Copy link
Copy Markdown
Contributor

For this and some of the other changes, is it worth keeping the "Annotations", and updating them with the new resolutions? And maybe preserving target anchors, by incorporating them in those annotation notes, so that if someone is following a link to removed content, they will get some information about where it has gone & why.

@dstorey

dstorey commented May 15, 2018

Copy link
Copy Markdown
Member Author

I prefer not to as it adds noise for people that don't know these features (which as they're not implemented will be most regular web developers) and I don't think other specs keep around things related to deferred/removed features outside of a changelog. Maybe we can add those links to the changelog (although I guess the URL wont work unless in single page more as the html page will be different and we don't redirect like HTML Living standard do if you link to a fragment identifier that has moved to a different page) or we can just link to SVG21 in the changelog where these features are mentioned once the URLs for those exist.

@dstorey

dstorey commented May 15, 2018

Copy link
Copy Markdown
Member Author

@svgeesus do you have feedback from Amelia's question above about if we should change SVG Colour or leave as is? I'd like to get this PR merged soon if possible.

@dstorey

dstorey commented May 18, 2018

Copy link
Copy Markdown
Member Author

In the interests of a speedy resolve, I've reverted the colour spec change.
@AmeliaBR / @dirkschulze I think this is ready to be signed off now?

@AmeliaBR AmeliaBR left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this and the cursor changes, are you able to also patch the changes into the svg-next branch? (To help distinguish the permanent removals from the deferments, and help us get ready for a 2.1 FPWD.)

I don't think you can do that in the GitHub interface, would need to use a separate git client.

@dstorey

dstorey commented May 18, 2018

Copy link
Copy Markdown
Member Author

I can look into it over the weekend. It might have to be a separate PRs as the original isolated PRs had merge conflicts where the other gradients were allowed on the same elements etc.

@dstorey
dstorey merged commit f05f02e into w3c:master May 18, 2018
sideshowbarker added a commit to w3c/browser-compat-data that referenced this pull request Feb 12, 2020
w3c/svgwg#450 removed the <solidcolor> element
and SVGSolidcolorElement interface from the SVG spec.

w3c/svgwg@f05f02e
queengooborg pushed a commit to mdn/browser-compat-data that referenced this pull request Feb 13, 2020
w3c/svgwg#450 removed the <solidcolor> element
and SVGSolidcolorElement interface from the SVG spec.

w3c/svgwg@f05f02e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants