close
Skip to content

Fixes #405 update description of when visibility applies#430

Merged
AmeliaBR merged 4 commits into
w3c:masterfrom
dstorey:visibility-editorial
Aug 13, 2018
Merged

Fixes #405 update description of when visibility applies#430
AmeliaBR merged 4 commits into
w3c:masterfrom
dstorey:visibility-editorial

Conversation

@dstorey

@dstorey dstorey commented May 2, 2018

Copy link
Copy Markdown
Member

No description provided.

@dirkschulze dirkschulze left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be a normative change. Maybe add a note in changes?

@dstorey

dstorey commented May 4, 2018

Copy link
Copy Markdown
Member Author

@dirkschulze / @AmeliaBR I think this is ready now?

@dirkschulze dirkschulze left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we need to rephrase this sentence. By definition, the property applies to all elements. From CSS:

Applies to: | all elements

Here we talk what the affective use of the property is. Don’t use “applies” at all. That just confuses where it can set to and what affect it means there.

@AmeliaBR

AmeliaBR commented May 5, 2018

Copy link
Copy Markdown
Contributor

@dirkschulze That's a valid point. Maybe "directly affects rendering of" instead of "directly applies to"?

@AmeliaBR
AmeliaBR merged commit a90be8c into w3c:master Aug 13, 2018
AmeliaBR added a commit that referenced this pull request Aug 13, 2018
- Add issue/PR links to the changes that were just merged (PR #485 and #430),
  to be consistent with patterns from PR #521
  (Next time, need to remember to do this before merging!)

- Used consistent wording for removed appendices.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants