close
Skip to content

perf: lazy load workbox-build to reduce config loading time#244

Merged
userquin merged 1 commit into
vite-pwa:mainfrom
sapphi-red:perf/lazy-load-workbox-build
Apr 18, 2022
Merged

perf: lazy load workbox-build to reduce config loading time#244
userquin merged 1 commit into
vite-pwa:mainfrom
sapphi-red:perf/lazy-load-workbox-build

Conversation

@sapphi-red

@sapphi-red sapphi-red commented Mar 11, 2022

Copy link
Copy Markdown
Contributor

I was thinking that vite's starting up time was slow in my project.
I digged down a bit and found that evaluating workbox-build was making it slow.

This PR changes workbox-build to be lazy loaded.
Since workbox-build is not always used, I think it is ok to do this.

Without this PR, my project takes about 1300 - 1500ms to start up.
With this PR, it takes about 500 - 600ms.

These values are obtained from output with DEBUG="vite:config" npm run dev like bundled config file loaded in 565.03ms +0ms.

@netlify

netlify Bot commented Mar 11, 2022

Copy link
Copy Markdown

✔️ Deploy Preview for vite-plugin-pwa ready!

🔨 Explore the source changes: 68ac570

🔍 Inspect the deploy log: https://app.netlify.com/sites/vite-plugin-pwa/deploys/622b0abc665fa600097745fd

😎 Browse the preview: https://deploy-preview-244--vite-plugin-pwa.netlify.app

@userquin

userquin commented Apr 3, 2022

Copy link
Copy Markdown
Member

@sapphi-red

sorry for the delay, testing with vitesse template also the dev startup from 2s to 1.2s, loading workbox-build on demand:

  vite v2.9.0 dev server running at:

  > Local: http://localhost:3333/
  > Network: use `--host` to expose

  ready in 1201ms.

with static import:

  vite v2.9.0 dev server running at:

  > Local: http://localhost:3333/
  > Network: use `--host` to expose

  ready in 2069ms.

@userquin
userquin merged commit 1873302 into vite-pwa:main Apr 18, 2022
@sapphi-red
sapphi-red deleted the perf/lazy-load-workbox-build branch April 19, 2022 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants