feat(vrl): add encode_zstd and decode_zstd functions#16060
Conversation
- add encode_zstd and decode_zstd functions - add tests - add documentation
✅ Deploy Preview for vector-project canceled.
|
✅ Deploy Preview for vrl-playground ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Regression Test Results
Run ID: 09291900-0f56-4c1e-9c43-7ab9d9a497e8 Explanation
A regression test is an integrated performance test for
The table below, if present, lists those experiments that have experienced a
statistically significant change in their No interesting changes in Fine details of change detection per experiment.
|
- fix unit-tests - make encode_zstd function infallible - fix documentation
Regression Test Results
Run ID: 48d8a9f7-968c-42a1-a803-aa83316ab055 Explanation
A regression test is an integrated performance test for
The table below, if present, lists those experiments that have experienced a
statistically significant change in their No interesting changes in Fine details of change detection per experiment.
|
|
Not sure about the current errors, but it seems like |
I think you can enable the |
- enabled wasm feature in zstd crate
Regression Test Results
Run ID: 8d43d188-8b94-4916-84d2-19e15672e15e Explanation
A regression test is an integrated performance test for
The table below, if present, lists those experiments that have experienced a
statistically significant change in their Changes in
Fine details of change detection per experiment.
|
|
@bruceg after the enabling I see here two options:
What do you think? |
Ah, yeah, I see it. I think what we need to do here is add clang to the build pipeline for the vrl-web-playground. You can see the entrypoint for this here as the build happens completely on Netlify: https://github.com/vectordotdev/vector/blob/master/lib/vrl/web-playground/netlify.toml . In this case I'd probably reuse |
404006f to
634c336
Compare
Regression Test Results
Run ID: b6dd657e-8dab-4773-aa6d-a501c7bd2ed6 Explanation
A regression test is an integrated performance test for
The table below, if present, lists those experiments that have experienced a
statistically significant change in their No interesting changes in Fine details of change detection per experiment.
|
Regression Test Results
Run ID: b0a069a9-6241-4781-b394-f9861881515e Explanation
A regression test is an integrated performance test for
The table below, if present, lists those experiments that have experienced a
statistically significant change in their No interesting changes in Fine details of change detection per experiment.
|
Regression Test Results
Run ID: 3b3c8d49-2c0d-4705-8cba-dcf4dac5399a Explanation
A regression test is an integrated performance test for
The table below, if present, lists those experiments that have experienced a
statistically significant change in their No interesting changes in Fine details of change detection per experiment.
|
|
@jszwedko I have added What do we need to do next with it? I suggest just disabling |
@bruceg hopefully you could help here. |
|
Hmm, I'm actually getting SIGSEVs when trying to build the playground with these changes. Netlify seems to be hitting that as well, but this seems different from issue you found: WebAssembly/binaryen#4630. Are you seeing a different error when trying to build locally? In any event, it actually looks like using a newer version of |
|
Is there a way to drop the already existing cache to test? |
Regression Detector ResultsRun ID: 617b7d87-641f-412f-a7f6-6ff36973e88e ExplanationA regression test is an integrated performance test for The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed. Changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%:
Fine details of change detection per experiment.
|
|
I dropped the cache and it looks good! Thanks for this contribution @zamazan4ik ! |
|
Merging since failed check was Netlify, but the subsequent build worked even though it didn't notify GHA of success. |
Adds
encode_zstdanddecode_zstdfunctions as discussed here: #15978 (comment)I think this should be merged after #16039