close
Skip to content

feat(vrl): add encode_zstd and decode_zstd functions#16060

Merged
jszwedko merged 6 commits into
vectordotdev:masterfrom
zamazan4ik:feature/add_encode_decode_zstd
Feb 21, 2023
Merged

feat(vrl): add encode_zstd and decode_zstd functions#16060
jszwedko merged 6 commits into
vectordotdev:masterfrom
zamazan4ik:feature/add_encode_decode_zstd

Conversation

@zamazan4ik

Copy link
Copy Markdown

Adds encode_zstd and decode_zstd functions as discussed here: #15978 (comment)

I think this should be merged after #16039

- add encode_zstd and decode_zstd functions
- add tests
- add documentation
@netlify

netlify Bot commented Jan 21, 2023

Copy link
Copy Markdown

Deploy Preview for vector-project canceled.

Name Link
🔨 Latest commit fc4d569
🔍 Latest deploy log https://app.netlify.com/sites/vector-project/deploys/63eecbf437b7b1000830876d

@netlify

netlify Bot commented Jan 21, 2023

Copy link
Copy Markdown

Deploy Preview for vrl-playground ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/vrl-playground/deploys/63ef817f51f2f776f0458bf4
😎 Deploy Preview https://deploy-preview-16060--vrl-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions Bot added domain: external docs Anything related to Vector's external, public documentation domain: vrl Anything related to the Vector Remap Language labels Jan 21, 2023
@github-actions

Copy link
Copy Markdown
Contributor

Regression Test Results

Run ID: 09291900-0f56-4c1e-9c43-7ab9d9a497e8
Baseline: eeb2bb5
Comparison: b117b3f
Total vector CPUs: 7

Explanation

A regression test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their bytes_written_per_cpu_second performance between baseline and comparison SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±5% change in mean bytes_written_per_cpu_second are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in bytes_written_per_cpu_second with confidence ≥ 90.00% and absolute Δ mean >= ±5%.

Fine details of change detection per experiment.
experiment Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
syslog_regex_logs2metric_ddmetrics 169.37KiB/CPU-s 4.69 100.00% 3.53MiB/CPU-s 396.43KiB/CPU-s 5.12KiB/CPU-s 0.0 0.109814 3.69MiB/CPU-s 413.35KiB/CPU-s 5.34KiB/CPU-s 0.0 0.109371 True False
http_to_http_acks 147.39KiB/CPU-s 2.75 99.64% 5.23MiB/CPU-s 2.68MiB/CPU-s 35.42KiB/CPU-s 0.0 0.512808 5.37MiB/CPU-s 2.74MiB/CPU-s 36.17KiB/CPU-s 0.0 0.509579 True False
datadog_agent_remap_blackhole_acks 753.23KiB/CPU-s 2.41 100.00% 30.58MiB/CPU-s 1.58MiB/CPU-s 20.91KiB/CPU-s 0.0 0.051712 31.31MiB/CPU-s 803.29KiB/CPU-s 10.37KiB/CPU-s 0.0 0.025051 False False
datadog_agent_remap_datadog_logs_acks 762.93KiB/CPU-s 2.25 100.00% 33.16MiB/CPU-s 1.63MiB/CPU-s 21.48KiB/CPU-s 0.0 0.049027 33.9MiB/CPU-s 1.04MiB/CPU-s 13.68KiB/CPU-s 0.0 0.030547 False False
splunk_hec_route_s3 45.9KiB/CPU-s 0.39 99.99% 11.63MiB/CPU-s 653.71KiB/CPU-s 8.43KiB/CPU-s 0.0 0.054894 11.67MiB/CPU-s 630.67KiB/CPU-s 8.14KiB/CPU-s 0.0 0.052756 False False
syslog_splunk_hec_logs 21.87KiB/CPU-s 0.24 100.00% 8.9MiB/CPU-s 247.94KiB/CPU-s 3.2KiB/CPU-s 0.0 0.027216 8.92MiB/CPU-s 268.2KiB/CPU-s 3.46KiB/CPU-s 0.0 0.029369 False False
http_to_http_json 7.23KiB/CPU-s 0.05 87.09% 13.59MiB/CPU-s 271.46KiB/CPU-s 3.5KiB/CPU-s 0.0 0.019504 13.6MiB/CPU-s 250.61KiB/CPU-s 3.23KiB/CPU-s 0.0 0.017996 False False
splunk_hec_to_splunk_hec_logs_noack 5.78KiB/CPU-s 0.04 86.59% 13.62MiB/CPU-s 231.7KiB/CPU-s 2.99KiB/CPU-s 0.0 0.016613 13.63MiB/CPU-s 188.95KiB/CPU-s 2.44KiB/CPU-s 0.0 0.013542 False False
http_to_http_noack 4.1KiB/CPU-s 0.03 57.65% 13.61MiB/CPU-s 304.43KiB/CPU-s 3.93KiB/CPU-s 0.0 0.021836 13.62MiB/CPU-s 255.07KiB/CPU-s 3.29KiB/CPU-s 0.0 0.01829 False False
fluent_elasticsearch -270.69B/CPU-s -0.0 37.65% 45.41MiB/CPU-s 29.74KiB/CPU-s 388.7B/CPU-s 0.0 0.000639 45.41MiB/CPU-s 29.93KiB/CPU-s 391.16B/CPU-s 0.0 0.000644 False False
file_to_blackhole -142.94B/CPU-s -0.0 0.52% 54.49MiB/CPU-s 1.16MiB/CPU-s 15.27KiB/CPU-s 0.0 0.02121 54.49MiB/CPU-s 1.13MiB/CPU-s 14.86KiB/CPU-s 0.0 0.020657 False False
enterprise_http_to_http 32.26B/CPU-s 0.0 0.61% 13.62MiB/CPU-s 224.8KiB/CPU-s 2.9KiB/CPU-s 0.0 0.016117 13.62MiB/CPU-s 224.35KiB/CPU-s 2.9KiB/CPU-s 0.0 0.016084 False False
splunk_hec_indexer_ack_blackhole 295.47B/CPU-s 0.0 5.02% 13.62MiB/CPU-s 251.96KiB/CPU-s 3.25KiB/CPU-s 0.0 0.018069 13.62MiB/CPU-s 250.64KiB/CPU-s 3.23KiB/CPU-s 0.0 0.017974 False False
splunk_hec_to_splunk_hec_logs_acks -3.09KiB/CPU-s -0.02 32.92% 13.62MiB/CPU-s 367.79KiB/CPU-s 4.75KiB/CPU-s 0.0 0.026376 13.61MiB/CPU-s 427.27KiB/CPU-s 5.51KiB/CPU-s 0.0 0.030648 False False
syslog_humio_logs -41.23KiB/CPU-s -0.45 100.00% 8.99MiB/CPU-s 242.56KiB/CPU-s 3.13KiB/CPU-s 0.0 0.026344 8.95MiB/CPU-s 286.81KiB/CPU-s 3.7KiB/CPU-s 0.0 0.031289 False False
syslog_log2metric_splunk_hec_metrics -95.99KiB/CPU-s -1.02 100.00% 9.23MiB/CPU-s 257.6KiB/CPU-s 3.33KiB/CPU-s 0.0 0.027248 9.14MiB/CPU-s 523.82KiB/CPU-s 6.76KiB/CPU-s 0.0 0.055976 False False
datadog_agent_remap_datadog_logs -352.06KiB/CPU-s -1.02 100.00% 33.54MiB/CPU-s 1.7MiB/CPU-s 22.41KiB/CPU-s 0.0 0.050567 33.2MiB/CPU-s 1.43MiB/CPU-s 18.9KiB/CPU-s 0.0 0.04309 False False
syslog_log2metric_humio_metrics -93.42KiB/CPU-s -1.52 100.00% 5.99MiB/CPU-s 318.48KiB/CPU-s 4.11KiB/CPU-s 0.0 0.051902 5.9MiB/CPU-s 256.56KiB/CPU-s 3.31KiB/CPU-s 0.0 0.042457 False False
otlp_http_to_blackhole -28.24KiB/CPU-s -1.82 100.00% 1.51MiB/CPU-s 125.58KiB/CPU-s 1.62KiB/CPU-s 0.0 0.081103 1.48MiB/CPU-s 132.97KiB/CPU-s 1.72KiB/CPU-s 0.0 0.087469 False False
datadog_agent_remap_blackhole -684.1KiB/CPU-s -2.2 100.00% 30.43MiB/CPU-s 1.38MiB/CPU-s 18.3KiB/CPU-s 0.0 0.045489 29.77MiB/CPU-s 3.66MiB/CPU-s 48.4KiB/CPU-s 0.0 0.122965 True False
socket_to_socket_blackhole -335.17KiB/CPU-s -2.48 100.00% 13.21MiB/CPU-s 335.94KiB/CPU-s 4.34KiB/CPU-s 0.0 0.024836 12.88MiB/CPU-s 142.99KiB/CPU-s 1.85KiB/CPU-s 0.0 0.01084 False False
otlp_grpc_to_blackhole -26.87KiB/CPU-s -2.51 100.00% 1.04MiB/CPU-s 33.06KiB/CPU-s 437.09B/CPU-s 0.0 0.030896 1.02MiB/CPU-s 57.13KiB/CPU-s 754.77B/CPU-s 0.0 0.054762 False False
syslog_loki -264.79KiB/CPU-s -2.97 100.00% 8.71MiB/CPU-s 319.02KiB/CPU-s 4.12KiB/CPU-s 0.0 0.035778 8.45MiB/CPU-s 689.26KiB/CPU-s 8.9KiB/CPU-s 0.0 0.079667 False False
http_text_to_http_json -1.03MiB/CPU-s -4.2 100.00% 24.45MiB/CPU-s 586.02KiB/CPU-s 7.56KiB/CPU-s 0.0 0.023404 23.42MiB/CPU-s 615.65KiB/CPU-s 7.94KiB/CPU-s 0.0 0.025664 False False

- fix unit-tests
- make encode_zstd function infallible
- fix documentation
@github-actions

Copy link
Copy Markdown
Contributor

Regression Test Results

Run ID: 48d8a9f7-968c-42a1-a803-aa83316ab055
Baseline: a6ba367
Comparison: 348c26a
Total vector CPUs: 7

Explanation

A regression test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their bytes_written_per_cpu_second performance between baseline and comparison SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±5% change in mean bytes_written_per_cpu_second are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in bytes_written_per_cpu_second with confidence ≥ 90.00% and absolute Δ mean >= ±5%.

Fine details of change detection per experiment.
experiment Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
syslog_regex_logs2metric_ddmetrics 169.03KiB/CPU-s 4.68 100.00% 3.53MiB/CPU-s 339.94KiB/CPU-s 4.39KiB/CPU-s 0.0 0.094133 3.69MiB/CPU-s 436.79KiB/CPU-s 5.64KiB/CPU-s 0.0 0.115544 True False
syslog_humio_logs 390.77KiB/CPU-s 4.31 100.00% 8.86MiB/CPU-s 398.13KiB/CPU-s 5.14KiB/CPU-s 0.0 0.043859 9.25MiB/CPU-s 144.12KiB/CPU-s 1.86KiB/CPU-s 0.0 0.015221 False False
syslog_log2metric_splunk_hec_metrics 255.58KiB/CPU-s 2.75 100.00% 9.07MiB/CPU-s 463.63KiB/CPU-s 5.99KiB/CPU-s 0.0 0.049938 9.32MiB/CPU-s 330.62KiB/CPU-s 4.27KiB/CPU-s 0.0 0.034657 False False
datadog_agent_remap_blackhole 819.27KiB/CPU-s 2.65 100.00% 30.14MiB/CPU-s 1.85MiB/CPU-s 24.52KiB/CPU-s 0.0 0.061527 30.94MiB/CPU-s 782.84KiB/CPU-s 10.1KiB/CPU-s 0.0 0.02471 False False
syslog_splunk_hec_logs 171.95KiB/CPU-s 1.91 100.00% 8.78MiB/CPU-s 212.97KiB/CPU-s 2.75KiB/CPU-s 0.0 0.023682 8.95MiB/CPU-s 272.58KiB/CPU-s 3.52KiB/CPU-s 0.0 0.029741 False False
otlp_grpc_to_blackhole 15.83KiB/CPU-s 1.52 100.00% 1.02MiB/CPU-s 45.19KiB/CPU-s 597.44B/CPU-s 0.0 0.043371 1.03MiB/CPU-s 55.45KiB/CPU-s 732.5B/CPU-s 0.0 0.05242 False False
http_to_http_json 139.5KiB/CPU-s 1.01 100.00% 13.46MiB/CPU-s 432.74KiB/CPU-s 5.58KiB/CPU-s 0.0 0.031397 13.59MiB/CPU-s 253.23KiB/CPU-s 3.27KiB/CPU-s 0.0 0.018189 False False
http_to_http_acks 51.81KiB/CPU-s 0.97 68.16% 5.21MiB/CPU-s 2.77MiB/CPU-s 36.67KiB/CPU-s 0.0 0.532105 5.26MiB/CPU-s 2.78MiB/CPU-s 36.77KiB/CPU-s 0.0 0.528521 True False
datadog_agent_remap_datadog_logs_acks 326.15KiB/CPU-s 0.95 100.00% 33.49MiB/CPU-s 1.48MiB/CPU-s 19.59KiB/CPU-s 0.0 0.044263 33.81MiB/CPU-s 1.21MiB/CPU-s 16.0KiB/CPU-s 0.0 0.035796 False False
otlp_http_to_blackhole 9.66KiB/CPU-s 0.62 100.00% 1.52MiB/CPU-s 123.32KiB/CPU-s 1.59KiB/CPU-s 0.0 0.079476 1.52MiB/CPU-s 125.66KiB/CPU-s 1.62KiB/CPU-s 0.0 0.080482 False False
enterprise_http_to_http 8.46KiB/CPU-s 0.06 95.91% 13.62MiB/CPU-s 283.51KiB/CPU-s 3.66KiB/CPU-s 0.0 0.020332 13.62MiB/CPU-s 149.54KiB/CPU-s 1.93KiB/CPU-s 0.0 0.010718 False False
splunk_hec_to_splunk_hec_logs_noack 4.75KiB/CPU-s 0.03 78.70% 13.62MiB/CPU-s 227.93KiB/CPU-s 2.94KiB/CPU-s 0.0 0.016342 13.62MiB/CPU-s 188.08KiB/CPU-s 2.43KiB/CPU-s 0.0 0.01348 False False
fluent_elasticsearch 124.6B/CPU-s 0.0 17.74% 45.41MiB/CPU-s 30.23KiB/CPU-s 395.27B/CPU-s 0.0 0.00065 45.41MiB/CPU-s 29.88KiB/CPU-s 390.61B/CPU-s 0.0 0.000643 False False
splunk_hec_to_splunk_hec_logs_acks 696.13B/CPU-s 0.0 8.09% 13.62MiB/CPU-s 371.97KiB/CPU-s 4.8KiB/CPU-s 0.0 0.026674 13.62MiB/CPU-s 361.78KiB/CPU-s 4.67KiB/CPU-s 0.0 0.025942 False False
file_to_blackhole -7.34KiB/CPU-s -0.01 27.16% 54.49MiB/CPU-s 1.1MiB/CPU-s 14.53KiB/CPU-s 0.0 0.020189 54.49MiB/CPU-s 1.16MiB/CPU-s 15.35KiB/CPU-s 0.0 0.021339 False False
splunk_hec_indexer_ack_blackhole -2.6KiB/CPU-s -0.02 43.19% 13.62MiB/CPU-s 248.07KiB/CPU-s 3.2KiB/CPU-s 0.0 0.017789 13.61MiB/CPU-s 251.86KiB/CPU-s 3.25KiB/CPU-s 0.0 0.018064 False False
http_to_http_noack -3.59KiB/CPU-s -0.03 49.37% 13.62MiB/CPU-s 284.69KiB/CPU-s 3.67KiB/CPU-s 0.0 0.020417 13.61MiB/CPU-s 306.69KiB/CPU-s 3.96KiB/CPU-s 0.0 0.022 False False
datadog_agent_remap_datadog_logs -20.08KiB/CPU-s -0.06 56.86% 33.85MiB/CPU-s 1.37MiB/CPU-s 18.07KiB/CPU-s 0.0 0.040405 33.83MiB/CPU-s 1.36MiB/CPU-s 18.02KiB/CPU-s 0.0 0.040329 False False
splunk_hec_route_s3 -59.53KiB/CPU-s -0.5 100.00% 11.6MiB/CPU-s 636.42KiB/CPU-s 8.21KiB/CPU-s 0.0 0.053575 11.54MiB/CPU-s 622.88KiB/CPU-s 8.04KiB/CPU-s 0.0 0.052699 False False
datadog_agent_remap_blackhole_acks -231.25KiB/CPU-s -0.74 100.00% 30.68MiB/CPU-s 1.53MiB/CPU-s 20.26KiB/CPU-s 0.0 0.049937 30.46MiB/CPU-s 1.72MiB/CPU-s 22.73KiB/CPU-s 0.0 0.056447 False False
socket_to_socket_blackhole -177.15KiB/CPU-s -1.3 100.00% 13.33MiB/CPU-s 305.39KiB/CPU-s 3.94KiB/CPU-s 0.0 0.022373 13.16MiB/CPU-s 537.65KiB/CPU-s 6.94KiB/CPU-s 0.0 0.039908 False False
syslog_log2metric_humio_metrics -99.79KiB/CPU-s -1.62 100.00% 6.03MiB/CPU-s 391.37KiB/CPU-s 5.05KiB/CPU-s 0.0 0.063335 5.94MiB/CPU-s 290.56KiB/CPU-s 3.75KiB/CPU-s 0.0 0.047792 False False
syslog_loki -163.73KiB/CPU-s -1.82 100.00% 8.77MiB/CPU-s 262.41KiB/CPU-s 3.39KiB/CPU-s 0.0 0.029221 8.61MiB/CPU-s 342.84KiB/CPU-s 4.43KiB/CPU-s 0.0 0.038886 False False
http_text_to_http_json -751.31KiB/CPU-s -3.0 100.00% 24.48MiB/CPU-s 603.14KiB/CPU-s 7.79KiB/CPU-s 0.0 0.024064 23.74MiB/CPU-s 678.22KiB/CPU-s 8.75KiB/CPU-s 0.0 0.027895 False False

@zamazan4ik

Copy link
Copy Markdown
Author

Not sure about the current errors, but it seems like encode/decode_zstd could not be used in WASM due to dependency on zstd-sys which requires Clang installed. Do we need to tweak somehow the build or just remove the functions from Web Playground?

@jszwedko

Copy link
Copy Markdown
Contributor

Not sure about the current errors, but it seems like encode/decode_zstd could not be used in WASM due to dependency on zstd-sys which requires Clang installed. Do we need to tweak somehow the build or just remove the functions from Web Playground?

I think you can enable the wasm feature for the zstd crate.

- enabled wasm feature in zstd crate
@github-actions

Copy link
Copy Markdown
Contributor

Regression Test Results

Run ID: 8d43d188-8b94-4916-84d2-19e15672e15e
Baseline: 2f3d155
Comparison: 6976df5
Total vector CPUs: 7

Explanation

A regression test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their bytes_written_per_cpu_second performance between baseline and comparison SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±5% change in mean bytes_written_per_cpu_second are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting changes are observed.

Changes in bytes_written_per_cpu_second with confidence ≥ 90.00% and absolute Δ mean >= ±5%:

experiment Δ mean Δ mean % confidence
syslog_log2metric_splunk_hec_metrics 575.2KiB/CPU-s 6.43 100.00%
Fine details of change detection per experiment.
experiment Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
syslog_log2metric_splunk_hec_metrics 575.2KiB/CPU-s 6.43 100.00% 8.74MiB/CPU-s 431.35KiB/CPU-s 5.57KiB/CPU-s 0.0 0.048213 9.3MiB/CPU-s 402.28KiB/CPU-s 5.19KiB/CPU-s 0.0 0.042248 False False
socket_to_socket_blackhole 444.71KiB/CPU-s 3.34 100.00% 13.01MiB/CPU-s 309.42KiB/CPU-s 3.99KiB/CPU-s 0.0 0.023218 13.45MiB/CPU-s 110.34KiB/CPU-s 1.43KiB/CPU-s 0.0 0.008012 False False
datadog_agent_remap_blackhole_acks 895.69KiB/CPU-s 2.95 100.00% 29.61MiB/CPU-s 1.14MiB/CPU-s 15.04KiB/CPU-s 0.0 0.038403 30.49MiB/CPU-s 1.34MiB/CPU-s 17.76KiB/CPU-s 0.0 0.044065 False False
otlp_grpc_to_blackhole 25.47KiB/CPU-s 2.41 100.00% 1.03MiB/CPU-s 39.61KiB/CPU-s 523.62B/CPU-s 0.0 0.037538 1.06MiB/CPU-s 49.61KiB/CPU-s 655.39B/CPU-s 0.0 0.045899 False False
syslog_splunk_hec_logs 203.11KiB/CPU-s 2.28 100.00% 8.68MiB/CPU-s 167.08KiB/CPU-s 2.16KiB/CPU-s 0.0 0.018787 8.88MiB/CPU-s 275.76KiB/CPU-s 3.56KiB/CPU-s 0.0 0.030314 False False
syslog_log2metric_humio_metrics 133.67KiB/CPU-s 2.26 100.00% 5.78MiB/CPU-s 283.39KiB/CPU-s 3.66KiB/CPU-s 0.0 0.047899 5.91MiB/CPU-s 311.35KiB/CPU-s 4.02KiB/CPU-s 0.0 0.051463 False False
http_text_to_http_json 515.81KiB/CPU-s 2.13 100.00% 23.65MiB/CPU-s 838.45KiB/CPU-s 10.82KiB/CPU-s 0.0 0.034626 24.15MiB/CPU-s 649.75KiB/CPU-s 8.39KiB/CPU-s 0.0 0.026273 False False
syslog_humio_logs 171.16KiB/CPU-s 1.92 100.00% 8.7MiB/CPU-s 480.05KiB/CPU-s 6.19KiB/CPU-s 0.0 0.053892 8.87MiB/CPU-s 304.44KiB/CPU-s 3.93KiB/CPU-s 0.0 0.033533 False False
otlp_http_to_blackhole 26.83KiB/CPU-s 1.72 100.00% 1.52MiB/CPU-s 114.23KiB/CPU-s 1.47KiB/CPU-s 0.0 0.073348 1.55MiB/CPU-s 118.94KiB/CPU-s 1.53KiB/CPU-s 0.0 0.075082 False False
datadog_agent_remap_datadog_logs 416.01KiB/CPU-s 1.24 100.00% 32.75MiB/CPU-s 1.6MiB/CPU-s 21.09KiB/CPU-s 0.0 0.048761 33.16MiB/CPU-s 1.81MiB/CPU-s 23.87KiB/CPU-s 0.0 0.054499 False False
splunk_hec_route_s3 72.83KiB/CPU-s 0.63 100.00% 11.28MiB/CPU-s 860.93KiB/CPU-s 11.11KiB/CPU-s 0.0 0.07452 11.35MiB/CPU-s 613.51KiB/CPU-s 7.92KiB/CPU-s 0.0 0.052771 False False
http_to_http_json 64.39KiB/CPU-s 0.47 100.00% 13.52MiB/CPU-s 344.2KiB/CPU-s 4.44KiB/CPU-s 0.0 0.024869 13.58MiB/CPU-s 285.85KiB/CPU-s 3.69KiB/CPU-s 0.0 0.020557 False False
syslog_loki 28.99KiB/CPU-s 0.33 100.00% 8.68MiB/CPU-s 194.06KiB/CPU-s 2.5KiB/CPU-s 0.0 0.021827 8.71MiB/CPU-s 306.27KiB/CPU-s 3.95KiB/CPU-s 0.0 0.034334 False False
splunk_hec_to_splunk_hec_logs_noack 4.36KiB/CPU-s 0.03 74.47% 13.62MiB/CPU-s 227.08KiB/CPU-s 2.93KiB/CPU-s 0.0 0.016279 13.63MiB/CPU-s 191.45KiB/CPU-s 2.47KiB/CPU-s 0.0 0.013721 False False
enterprise_http_to_http 4.22KiB/CPU-s 0.03 58.46% 13.61MiB/CPU-s 308.73KiB/CPU-s 3.98KiB/CPU-s 0.0 0.022144 13.62MiB/CPU-s 256.07KiB/CPU-s 3.31KiB/CPU-s 0.0 0.018362 False False
http_to_http_noack 283.85B/CPU-s 0.0 4.26% 13.62MiB/CPU-s 286.36KiB/CPU-s 3.7KiB/CPU-s 0.0 0.020537 13.62MiB/CPU-s 282.56KiB/CPU-s 3.65KiB/CPU-s 0.0 0.020264 False False
fluent_elasticsearch 288.8B/CPU-s 0.0 39.57% 45.41MiB/CPU-s 30.35KiB/CPU-s 396.65B/CPU-s 0.0 0.000653 45.41MiB/CPU-s 29.96KiB/CPU-s 391.42B/CPU-s 0.0 0.000644 False False
splunk_hec_to_splunk_hec_logs_acks 135.2B/CPU-s 0.0 1.70% 13.62MiB/CPU-s 340.38KiB/CPU-s 4.39KiB/CPU-s 0.0 0.024409 13.62MiB/CPU-s 338.11KiB/CPU-s 4.36KiB/CPU-s 0.0 0.024246 False False
file_to_blackhole -4.51KiB/CPU-s -0.01 16.16% 54.49MiB/CPU-s 1.14MiB/CPU-s 15.06KiB/CPU-s 0.0 0.020923 54.49MiB/CPU-s 1.23MiB/CPU-s 16.18KiB/CPU-s 0.0 0.022502 False False
splunk_hec_indexer_ack_blackhole -1.26KiB/CPU-s -0.01 21.77% 13.62MiB/CPU-s 246.72KiB/CPU-s 3.18KiB/CPU-s 0.0 0.017693 13.62MiB/CPU-s 254.02KiB/CPU-s 3.28KiB/CPU-s 0.0 0.018218 False False
datadog_agent_remap_datadog_logs_acks -39.45KiB/CPU-s -0.12 90.48% 33.22MiB/CPU-s 1.3MiB/CPU-s 17.17KiB/CPU-s 0.0 0.039114 33.18MiB/CPU-s 1.23MiB/CPU-s 16.25KiB/CPU-s 0.0 0.037069 False False
datadog_agent_remap_blackhole -197.3KiB/CPU-s -0.63 100.00% 30.54MiB/CPU-s 892.25KiB/CPU-s 11.52KiB/CPU-s 0.0 0.028532 30.34MiB/CPU-s 1.39MiB/CPU-s 18.39KiB/CPU-s 0.0 0.045856 False False
syslog_regex_logs2metric_ddmetrics -27.8KiB/CPU-s -0.79 100.00% 3.45MiB/CPU-s 243.71KiB/CPU-s 3.15KiB/CPU-s 0.0 0.069045 3.42MiB/CPU-s 290.0KiB/CPU-s 3.74KiB/CPU-s 0.0 0.082814 False False
http_to_http_acks -46.36KiB/CPU-s -0.86 62.83% 5.27MiB/CPU-s 2.76MiB/CPU-s 36.5KiB/CPU-s 0.0 0.523552 5.23MiB/CPU-s 2.79MiB/CPU-s 36.88KiB/CPU-s 0.0 0.533522 True False

@zamazan4ik

zamazan4ik commented Feb 1, 2023

Copy link
Copy Markdown
Author

@bruceg after the enabling wasm feature in the zstd crate it still does not work in Web due to a missing clang crate somewhere in the build pipeline.

I see here two options:

  • Install clang in the build pipeline. I do not know how to do it since I am not familiar at all with your CI
  • Disable encode/decode_zstd functions on VRL playground

What do you think?

@jszwedko

jszwedko commented Feb 1, 2023

Copy link
Copy Markdown
Contributor

@bruceg after the enabling wasm feature in the zstd crate it still does not work in Web due to a missing clang crate somewhere in the build pipeline.

I see here two options:

  • Install clang in the build pipeline. I do not know how to do it since I am not familiar at all with your CI
  • Disable encode/decode_zstd functions on VRL playground

What do you think?

Ah, yeah, I see it. I think what we need to do here is add clang to the build pipeline for the vrl-web-playground. You can see the entrypoint for this here as the build happens completely on Netlify: https://github.com/vectordotdev/vector/blob/master/lib/vrl/web-playground/netlify.toml . In this case I'd probably reuse ensure-wasm-pack-installed.sh to install all needed vrl-web-playground build dependencies (and rename it to something like bootstrap-vrl-web-playground.sh). Does that make sense?

@github-actions github-actions Bot added the domain: ci Anything related to Vector's CI environment label Feb 5, 2023
@zamazan4ik
zamazan4ik force-pushed the feature/add_encode_decode_zstd branch from 404006f to 634c336 Compare February 5, 2023 14:09
@github-actions

github-actions Bot commented Feb 5, 2023

Copy link
Copy Markdown
Contributor

Regression Test Results

Run ID: b6dd657e-8dab-4773-aa6d-a501c7bd2ed6
Baseline: 50933e9
Comparison: d8b5933
Total vector CPUs: 7

Explanation

A regression test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their bytes_written_per_cpu_second performance between baseline and comparison SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±5% change in mean bytes_written_per_cpu_second are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in bytes_written_per_cpu_second with confidence ≥ 90.00% and absolute Δ mean >= ±5%.

Fine details of change detection per experiment.
experiment Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
datadog_agent_remap_blackhole 1016.76KiB/CPU-s 3.28 100.00% 30.3MiB/CPU-s 1.44MiB/CPU-s 19.09KiB/CPU-s 0.0 0.047642 31.3MiB/CPU-s 844.1KiB/CPU-s 10.9KiB/CPU-s 0.0 0.026338 False False
http_to_http_acks 86.98KiB/CPU-s 1.62 90.74% 5.25MiB/CPU-s 2.78MiB/CPU-s 36.74KiB/CPU-s 0.0 0.530008 5.33MiB/CPU-s 2.75MiB/CPU-s 36.39KiB/CPU-s 0.0 0.516563 True False
splunk_hec_route_s3 185.19KiB/CPU-s 1.58 100.00% 11.47MiB/CPU-s 620.7KiB/CPU-s 8.01KiB/CPU-s 0.0 0.052828 11.65MiB/CPU-s 520.46KiB/CPU-s 6.72KiB/CPU-s 0.0 0.043609 False False
syslog_log2metric_humio_metrics 84.81KiB/CPU-s 1.38 100.00% 6.01MiB/CPU-s 315.13KiB/CPU-s 4.07KiB/CPU-s 0.0 0.0512 6.09MiB/CPU-s 152.22KiB/CPU-s 1.97KiB/CPU-s 0.0 0.024396 False False
datadog_agent_remap_datadog_logs_acks 447.68KiB/CPU-s 1.31 100.00% 33.37MiB/CPU-s 1.67MiB/CPU-s 22.07KiB/CPU-s 0.0 0.050056 33.81MiB/CPU-s 1.32MiB/CPU-s 17.49KiB/CPU-s 0.0 0.039159 False False
datadog_agent_remap_datadog_logs 426.88KiB/CPU-s 1.23 100.00% 33.88MiB/CPU-s 1.3MiB/CPU-s 17.15KiB/CPU-s 0.0 0.038317 34.3MiB/CPU-s 1.14MiB/CPU-s 15.01KiB/CPU-s 0.0 0.03314 False False
datadog_agent_remap_blackhole_acks 182.72KiB/CPU-s 0.57 100.00% 31.18MiB/CPU-s 1.25MiB/CPU-s 16.59KiB/CPU-s 0.0 0.040239 31.36MiB/CPU-s 713.14KiB/CPU-s 9.21KiB/CPU-s 0.0 0.022204 False False
enterprise_http_to_http 10.23KiB/CPU-s 0.07 96.16% 13.61MiB/CPU-s 329.57KiB/CPU-s 4.25KiB/CPU-s 0.0 0.023642 13.62MiB/CPU-s 194.55KiB/CPU-s 2.51KiB/CPU-s 0.0 0.013946 False False
splunk_hec_to_splunk_hec_logs_noack 6.92KiB/CPU-s 0.05 91.58% 13.62MiB/CPU-s 244.3KiB/CPU-s 3.15KiB/CPU-s 0.0 0.017517 13.63MiB/CPU-s 191.59KiB/CPU-s 2.47KiB/CPU-s 0.0 0.013731 False False
splunk_hec_to_splunk_hec_logs_acks 2.63KiB/CPU-s 0.02 30.53% 13.62MiB/CPU-s 375.18KiB/CPU-s 4.84KiB/CPU-s 0.0 0.026906 13.62MiB/CPU-s 357.79KiB/CPU-s 4.62KiB/CPU-s 0.0 0.025654 False False
http_to_http_noack 2.2KiB/CPU-s 0.02 25.91% 13.61MiB/CPU-s 376.09KiB/CPU-s 4.85KiB/CPU-s 0.0 0.026988 13.61MiB/CPU-s 352.54KiB/CPU-s 4.55KiB/CPU-s 0.0 0.025294 False False
http_to_http_json -160.25B/CPU-s -0.0 3.24% 13.62MiB/CPU-s 210.43KiB/CPU-s 2.72KiB/CPU-s 0.0 0.015084 13.62MiB/CPU-s 211.54KiB/CPU-s 2.73KiB/CPU-s 0.0 0.015164 False False
file_to_blackhole -1.44KiB/CPU-s -0.0 5.69% 54.49MiB/CPU-s 1.13MiB/CPU-s 14.87KiB/CPU-s 0.0 0.020659 54.49MiB/CPU-s 1.04MiB/CPU-s 13.68KiB/CPU-s 0.0 0.019016 False False
splunk_hec_indexer_ack_blackhole -947.56B/CPU-s -0.01 16.19% 13.62MiB/CPU-s 246.02KiB/CPU-s 3.17KiB/CPU-s 0.0 0.017641 13.62MiB/CPU-s 250.26KiB/CPU-s 3.23KiB/CPU-s 0.0 0.017945 False False
fluent_elasticsearch -3.88KiB/CPU-s -0.01 68.94% 45.41MiB/CPU-s 30.21KiB/CPU-s 394.9B/CPU-s 0.0 0.00065 45.41MiB/CPU-s 298.55KiB/CPU-s 3.81KiB/CPU-s 0.0 0.00642 False False
otlp_grpc_to_blackhole -1.64KiB/CPU-s -0.16 95.16% 1.03MiB/CPU-s 36.83KiB/CPU-s 486.82B/CPU-s 0.0 0.034886 1.03MiB/CPU-s 52.85KiB/CPU-s 698.2B/CPU-s 0.0 0.05014 False False
syslog_loki -15.28KiB/CPU-s -0.17 100.00% 8.81MiB/CPU-s 191.09KiB/CPU-s 2.47KiB/CPU-s 0.0 0.021183 8.79MiB/CPU-s 170.01KiB/CPU-s 2.19KiB/CPU-s 0.0 0.018878 False False
socket_to_socket_blackhole -59.03KiB/CPU-s -0.45 100.00% 12.86MiB/CPU-s 502.13KiB/CPU-s 6.48KiB/CPU-s 0.0 0.038117 12.81MiB/CPU-s 256.27KiB/CPU-s 3.31KiB/CPU-s 0.0 0.019541 False False
syslog_log2metric_splunk_hec_metrics -42.89KiB/CPU-s -0.45 100.00% 9.21MiB/CPU-s 283.77KiB/CPU-s 3.66KiB/CPU-s 0.0 0.030085 9.17MiB/CPU-s 406.98KiB/CPU-s 5.26KiB/CPU-s 0.0 0.043345 False False
syslog_splunk_hec_logs -54.64KiB/CPU-s -0.59 100.00% 9.04MiB/CPU-s 141.74KiB/CPU-s 1.83KiB/CPU-s 0.0 0.015311 8.99MiB/CPU-s 162.02KiB/CPU-s 2.09KiB/CPU-s 0.0 0.017606 False False
otlp_http_to_blackhole -18.94KiB/CPU-s -1.22 100.00% 1.51MiB/CPU-s 121.86KiB/CPU-s 1.57KiB/CPU-s 0.0 0.078687 1.49MiB/CPU-s 132.28KiB/CPU-s 1.71KiB/CPU-s 0.0 0.08647 False False
syslog_humio_logs -132.8KiB/CPU-s -1.43 100.00% 9.05MiB/CPU-s 198.14KiB/CPU-s 2.56KiB/CPU-s 0.0 0.021384 8.92MiB/CPU-s 345.19KiB/CPU-s 4.46KiB/CPU-s 0.0 0.037797 False False
http_text_to_http_json -434.28KiB/CPU-s -1.79 100.00% 23.75MiB/CPU-s 646.85KiB/CPU-s 8.35KiB/CPU-s 0.0 0.026598 23.32MiB/CPU-s 662.02KiB/CPU-s 8.54KiB/CPU-s 0.0 0.027716 False False
syslog_regex_logs2metric_ddmetrics -109.55KiB/CPU-s -2.9 100.00% 3.69MiB/CPU-s 440.48KiB/CPU-s 5.69KiB/CPU-s 0.0 0.116457 3.59MiB/CPU-s 429.22KiB/CPU-s 5.54KiB/CPU-s 0.0 0.116864 True False

@github-actions

github-actions Bot commented Feb 5, 2023

Copy link
Copy Markdown
Contributor

Regression Test Results

Run ID: b0a069a9-6241-4781-b394-f9861881515e
Baseline: 50933e9
Comparison: 404006f
Total vector CPUs: 7

Explanation

A regression test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their bytes_written_per_cpu_second performance between baseline and comparison SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±5% change in mean bytes_written_per_cpu_second are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in bytes_written_per_cpu_second with confidence ≥ 90.00% and absolute Δ mean >= ±5%.

Fine details of change detection per experiment.
experiment Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
syslog_regex_logs2metric_ddmetrics 40.02KiB/CPU-s 1.11 100.00% 3.54MiB/CPU-s 441.99KiB/CPU-s 5.71KiB/CPU-s 0.0 0.122039 3.58MiB/CPU-s 463.7KiB/CPU-s 5.99KiB/CPU-s 0.0 0.126633 True False
datadog_agent_remap_blackhole_acks 230.12KiB/CPU-s 0.72 100.00% 31.06MiB/CPU-s 1.75MiB/CPU-s 23.2KiB/CPU-s 0.0 0.05648 31.28MiB/CPU-s 1.03MiB/CPU-s 13.61KiB/CPU-s 0.0 0.032917 False False
datadog_agent_remap_datadog_logs 34.44KiB/CPU-s 0.1 79.33% 33.68MiB/CPU-s 1.56MiB/CPU-s 20.57KiB/CPU-s 0.0 0.04622 33.71MiB/CPU-s 1.36MiB/CPU-s 17.92KiB/CPU-s 0.0 0.040234 False False
enterprise_http_to_http 8.14KiB/CPU-s 0.06 91.95% 13.61MiB/CPU-s 305.61KiB/CPU-s 3.94KiB/CPU-s 0.0 0.021921 13.62MiB/CPU-s 191.67KiB/CPU-s 2.47KiB/CPU-s 0.0 0.01374 False False
splunk_hec_to_splunk_hec_logs_noack 5.89KiB/CPU-s 0.04 86.48% 13.62MiB/CPU-s 240.53KiB/CPU-s 3.1KiB/CPU-s 0.0 0.017247 13.62MiB/CPU-s 188.73KiB/CPU-s 2.44KiB/CPU-s 0.0 0.013527 False False
fluent_elasticsearch -348.14B/CPU-s -0.0 46.75% 45.41MiB/CPU-s 29.89KiB/CPU-s 390.73B/CPU-s 0.0 0.000643 45.41MiB/CPU-s 30.46KiB/CPU-s 397.96B/CPU-s 0.0 0.000655 False False
splunk_hec_indexer_ack_blackhole -1017.27B/CPU-s -0.01 17.36% 13.62MiB/CPU-s 244.97KiB/CPU-s 3.16KiB/CPU-s 0.0 0.017566 13.62MiB/CPU-s 251.48KiB/CPU-s 3.24KiB/CPU-s 0.0 0.018034 False False
file_to_blackhole -3.08KiB/CPU-s -0.01 11.88% 54.49MiB/CPU-s 1.09MiB/CPU-s 14.42KiB/CPU-s 0.0 0.020037 54.49MiB/CPU-s 1.12MiB/CPU-s 14.73KiB/CPU-s 0.0 0.020481 False False
splunk_hec_to_splunk_hec_logs_acks -1.6KiB/CPU-s -0.01 19.10% 13.62MiB/CPU-s 359.65KiB/CPU-s 4.64KiB/CPU-s 0.0 0.025792 13.61MiB/CPU-s 366.05KiB/CPU-s 4.72KiB/CPU-s 0.0 0.026254 False False
http_to_http_noack -4.24KiB/CPU-s -0.03 55.24% 13.62MiB/CPU-s 280.15KiB/CPU-s 3.62KiB/CPU-s 0.0 0.020091 13.61MiB/CPU-s 330.01KiB/CPU-s 4.26KiB/CPU-s 0.0 0.023674 False False
http_to_http_json -19.86KiB/CPU-s -0.14 100.00% 13.62MiB/CPU-s 220.97KiB/CPU-s 2.85KiB/CPU-s 0.0 0.015846 13.6MiB/CPU-s 249.75KiB/CPU-s 3.22KiB/CPU-s 0.0 0.017935 False False
http_to_http_acks -14.47KiB/CPU-s -0.27 22.06% 5.32MiB/CPU-s 2.75MiB/CPU-s 36.28KiB/CPU-s 0.0 0.516063 5.31MiB/CPU-s 2.78MiB/CPU-s 36.74KiB/CPU-s 0.0 0.52394 True False
syslog_loki -25.59KiB/CPU-s -0.28 100.00% 8.78MiB/CPU-s 179.58KiB/CPU-s 2.32KiB/CPU-s 0.0 0.019982 8.75MiB/CPU-s 272.17KiB/CPU-s 3.51KiB/CPU-s 0.0 0.030372 False False
syslog_splunk_hec_logs -45.17KiB/CPU-s -0.5 100.00% 8.91MiB/CPU-s 194.55KiB/CPU-s 2.51KiB/CPU-s 0.0 0.02132 8.87MiB/CPU-s 270.53KiB/CPU-s 3.49KiB/CPU-s 0.0 0.029793 False False
datadog_agent_remap_blackhole -180.77KiB/CPU-s -0.56 100.00% 31.34MiB/CPU-s 573.94KiB/CPU-s 7.41KiB/CPU-s 0.0 0.017883 31.16MiB/CPU-s 656.69KiB/CPU-s 8.48KiB/CPU-s 0.0 0.020577 False False
otlp_grpc_to_blackhole -8.37KiB/CPU-s -0.8 100.00% 1.03MiB/CPU-s 41.2KiB/CPU-s 544.72B/CPU-s 0.0 0.039186 1.02MiB/CPU-s 59.92KiB/CPU-s 791.48B/CPU-s 0.0 0.057442 False False
syslog_log2metric_splunk_hec_metrics -77.24KiB/CPU-s -0.81 100.00% 9.35MiB/CPU-s 301.08KiB/CPU-s 3.89KiB/CPU-s 0.0 0.031457 9.27MiB/CPU-s 302.11KiB/CPU-s 3.9KiB/CPU-s 0.0 0.031821 False False
syslog_log2metric_humio_metrics -57.3KiB/CPU-s -0.92 100.00% 6.11MiB/CPU-s 125.77KiB/CPU-s 1.62KiB/CPU-s 0.0 0.020094 6.06MiB/CPU-s 203.79KiB/CPU-s 2.63KiB/CPU-s 0.0 0.03286 False False
otlp_http_to_blackhole -17.66KiB/CPU-s -1.13 100.00% 1.52MiB/CPU-s 120.76KiB/CPU-s 1.56KiB/CPU-s 0.0 0.077585 1.5MiB/CPU-s 123.72KiB/CPU-s 1.6KiB/CPU-s 0.0 0.080398 False False
socket_to_socket_blackhole -161.65KiB/CPU-s -1.22 100.00% 12.98MiB/CPU-s 200.33KiB/CPU-s 2.59KiB/CPU-s 0.0 0.01507 12.82MiB/CPU-s 248.46KiB/CPU-s 3.21KiB/CPU-s 0.0 0.018921 False False
splunk_hec_route_s3 -229.23KiB/CPU-s -1.94 100.00% 11.52MiB/CPU-s 653.27KiB/CPU-s 8.43KiB/CPU-s 0.0 0.055367 11.3MiB/CPU-s 870.56KiB/CPU-s 11.24KiB/CPU-s 0.0 0.075245 False False
http_text_to_http_json -477.87KiB/CPU-s -1.97 100.00% 23.69MiB/CPU-s 554.11KiB/CPU-s 7.15KiB/CPU-s 0.0 0.022845 23.22MiB/CPU-s 833.29KiB/CPU-s 10.75KiB/CPU-s 0.0 0.035045 False False
syslog_humio_logs -212.04KiB/CPU-s -2.27 100.00% 9.11MiB/CPU-s 172.49KiB/CPU-s 2.23KiB/CPU-s 0.0 0.01848 8.91MiB/CPU-s 254.27KiB/CPU-s 3.28KiB/CPU-s 0.0 0.027876 False False
datadog_agent_remap_datadog_logs_acks -1.11MiB/CPU-s -3.32 100.00% 33.44MiB/CPU-s 1019.13KiB/CPU-s 13.15KiB/CPU-s 0.0 0.029764 32.32MiB/CPU-s 2.04MiB/CPU-s 26.96KiB/CPU-s 0.0 0.063099 False False

@github-actions

github-actions Bot commented Feb 5, 2023

Copy link
Copy Markdown
Contributor

Regression Test Results

Run ID: 3b3c8d49-2c0d-4705-8cba-dcf4dac5399a
Baseline: 50933e9
Comparison: 634c336
Total vector CPUs: 7

Explanation

A regression test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their bytes_written_per_cpu_second performance between baseline and comparison SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±5% change in mean bytes_written_per_cpu_second are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in bytes_written_per_cpu_second with confidence ≥ 90.00% and absolute Δ mean >= ±5%.

Fine details of change detection per experiment.
experiment Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
splunk_hec_route_s3 323.76KiB/CPU-s 2.8 100.00% 11.31MiB/CPU-s 743.95KiB/CPU-s 9.6KiB/CPU-s 0.0 0.064235 11.63MiB/CPU-s 535.62KiB/CPU-s 6.91KiB/CPU-s 0.0 0.04499 False False
syslog_log2metric_splunk_hec_metrics 221.06KiB/CPU-s 2.36 100.00% 9.13MiB/CPU-s 383.43KiB/CPU-s 4.95KiB/CPU-s 0.0 0.041012 9.35MiB/CPU-s 228.54KiB/CPU-s 2.95KiB/CPU-s 0.0 0.02388 False False
http_to_http_acks 73.27KiB/CPU-s 1.37 84.93% 5.22MiB/CPU-s 2.73MiB/CPU-s 36.08KiB/CPU-s 0.0 0.523058 5.29MiB/CPU-s 2.73MiB/CPU-s 36.03KiB/CPU-s 0.0 0.515341 True False
datadog_agent_remap_datadog_logs_acks 132.5KiB/CPU-s 0.39 100.00% 33.56MiB/CPU-s 1.4MiB/CPU-s 18.55KiB/CPU-s 0.0 0.04184 33.69MiB/CPU-s 1.14MiB/CPU-s 15.03KiB/CPU-s 0.0 0.033754 False False
enterprise_http_to_http 8.3KiB/CPU-s 0.06 95.54% 13.62MiB/CPU-s 281.36KiB/CPU-s 3.63KiB/CPU-s 0.0 0.020178 13.62MiB/CPU-s 152.8KiB/CPU-s 1.97KiB/CPU-s 0.0 0.010952 False False
splunk_hec_to_splunk_hec_logs_noack 7.04KiB/CPU-s 0.05 92.13% 13.62MiB/CPU-s 244.55KiB/CPU-s 3.16KiB/CPU-s 0.0 0.017535 13.63MiB/CPU-s 191.05KiB/CPU-s 2.47KiB/CPU-s 0.0 0.013692 False False
file_to_blackhole 4.19KiB/CPU-s 0.01 15.68% 54.49MiB/CPU-s 1.11MiB/CPU-s 14.6KiB/CPU-s 0.0 0.020279 54.49MiB/CPU-s 1.16MiB/CPU-s 15.33KiB/CPU-s 0.0 0.021307 False False
splunk_hec_indexer_ack_blackhole 1.94KiB/CPU-s 0.01 32.76% 13.62MiB/CPU-s 256.29KiB/CPU-s 3.31KiB/CPU-s 0.0 0.018381 13.62MiB/CPU-s 246.65KiB/CPU-s 3.18KiB/CPU-s 0.0 0.017687 False False
fluent_elasticsearch 246.35B/CPU-s 0.0 34.69% 45.41MiB/CPU-s 29.63KiB/CPU-s 387.23B/CPU-s 0.0 0.000637 45.41MiB/CPU-s 29.67KiB/CPU-s 387.97B/CPU-s 0.0 0.000638 False False
http_to_http_noack 26.78B/CPU-s 0.0 0.50% 13.62MiB/CPU-s 229.62KiB/CPU-s 2.96KiB/CPU-s 0.0 0.016463 13.62MiB/CPU-s 228.73KiB/CPU-s 2.95KiB/CPU-s 0.0 0.016399 False False
splunk_hec_to_splunk_hec_logs_acks -2.56KiB/CPU-s -0.02 29.46% 13.62MiB/CPU-s 362.6KiB/CPU-s 4.68KiB/CPU-s 0.0 0.026005 13.61MiB/CPU-s 379.37KiB/CPU-s 4.89KiB/CPU-s 0.0 0.027213 False False
http_to_http_json -4.53KiB/CPU-s -0.03 73.27% 13.62MiB/CPU-s 211.81KiB/CPU-s 2.73KiB/CPU-s 0.0 0.015183 13.62MiB/CPU-s 235.15KiB/CPU-s 3.03KiB/CPU-s 0.0 0.016862 False False
otlp_http_to_blackhole -4.12KiB/CPU-s -0.27 93.77% 1.51MiB/CPU-s 116.96KiB/CPU-s 1.51KiB/CPU-s 0.0 0.075488 1.51MiB/CPU-s 125.06KiB/CPU-s 1.61KiB/CPU-s 0.0 0.080932 False False
otlp_grpc_to_blackhole -4.16KiB/CPU-s -0.39 100.00% 1.04MiB/CPU-s 41.19KiB/CPU-s 544.38B/CPU-s 0.0 0.038681 1.04MiB/CPU-s 53.32KiB/CPU-s 704.36B/CPU-s 0.0 0.05027 False False
datadog_agent_remap_blackhole_acks -177.76KiB/CPU-s -0.55 100.00% 31.42MiB/CPU-s 794.65KiB/CPU-s 10.26KiB/CPU-s 0.0 0.024698 31.24MiB/CPU-s 954.84KiB/CPU-s 12.33KiB/CPU-s 0.0 0.029842 False False
datadog_agent_remap_datadog_logs -289.72KiB/CPU-s -0.84 100.00% 33.83MiB/CPU-s 1.32MiB/CPU-s 17.48KiB/CPU-s 0.0 0.039125 33.54MiB/CPU-s 1.6MiB/CPU-s 21.14KiB/CPU-s 0.0 0.047715 False False
syslog_humio_logs -80.25KiB/CPU-s -0.87 100.00% 9.02MiB/CPU-s 190.0KiB/CPU-s 2.45KiB/CPU-s 0.0 0.020561 8.95MiB/CPU-s 152.35KiB/CPU-s 1.97KiB/CPU-s 0.0 0.016631 False False
syslog_loki -92.84KiB/CPU-s -1.03 100.00% 8.77MiB/CPU-s 179.03KiB/CPU-s 2.31KiB/CPU-s 0.0 0.019932 8.68MiB/CPU-s 269.93KiB/CPU-s 3.48KiB/CPU-s 0.0 0.030366 False False
syslog_log2metric_humio_metrics -80.88KiB/CPU-s -1.32 100.00% 6.0MiB/CPU-s 225.61KiB/CPU-s 2.91KiB/CPU-s 0.0 0.036738 5.92MiB/CPU-s 346.41KiB/CPU-s 4.47KiB/CPU-s 0.0 0.057163 False False
syslog_splunk_hec_logs -149.17KiB/CPU-s -1.62 100.00% 8.98MiB/CPU-s 186.08KiB/CPU-s 2.4KiB/CPU-s 0.0 0.020229 8.84MiB/CPU-s 249.91KiB/CPU-s 3.22KiB/CPU-s 0.0 0.027615 False False
http_text_to_http_json -436.62KiB/CPU-s -1.78 100.00% 23.96MiB/CPU-s 532.1KiB/CPU-s 7.24KiB/CPU-s 0.0 0.021684 23.53MiB/CPU-s 554.54KiB/CPU-s 7.15KiB/CPU-s 0.0 0.023008 False False
datadog_agent_remap_blackhole -809.33KiB/CPU-s -2.55 100.00% 30.94MiB/CPU-s 860.21KiB/CPU-s 11.11KiB/CPU-s 0.0 0.027145 30.15MiB/CPU-s 1.31MiB/CPU-s 17.35KiB/CPU-s 0.0 0.043527 False False
socket_to_socket_blackhole -533.62KiB/CPU-s -4.0 100.00% 13.04MiB/CPU-s 160.18KiB/CPU-s 2.07KiB/CPU-s 0.0 0.011992 12.52MiB/CPU-s 475.51KiB/CPU-s 6.14KiB/CPU-s 0.0 0.037081 False False
syslog_regex_logs2metric_ddmetrics -171.3KiB/CPU-s -4.38 100.00% 3.82MiB/CPU-s 467.69KiB/CPU-s 6.04KiB/CPU-s 0.0 0.119588 3.65MiB/CPU-s 492.87KiB/CPU-s 6.36KiB/CPU-s 0.0 0.131802 True False

@zamazan4ik

zamazan4ik commented Feb 5, 2023

Copy link
Copy Markdown
Author

@jszwedko I have added clang to the build. Right now wasm-opt is segfaulting in the build pipeline. I found possibly the related issue in the upstream (spoiler: no viable solution is available right now): WebAssembly/binaryen#4630

What do we need to do next with it? I suggest just disabling encode/decode_zstd on the VRL playground with a note, of why we did it (with a link to the wasm-opt issue).

@zamazan4ik

Copy link
Copy Markdown
Author

I have added clang to the build. Right now wasm-opt is segfaulting in the build pipeline. I found possibly the related issue in the upstream (spoiler: no viable solution is available right now): WebAssembly/binaryen#4630

What do we need to do next with it? I suggest just disabling encode/decode_zstd on the VRL playground with a note, of why we did it (with a link to the wasm-opt issue).

@bruceg hopefully you could help here.

@jszwedko

Copy link
Copy Markdown
Contributor

Hmm, I'm actually getting SIGSEVs when trying to build the playground with these changes. Netlify seems to be hitting that as well, but this seems different from issue you found: WebAssembly/binaryen#4630. Are you seeing a different error when trying to build locally?

In any event, it actually looks like using a newer version of wasm-pack resolves the issue. I was able to install https://github.com/rustwasm/wasm-pack.git at e3582b7 and it built ok. Would you want to update scripts/ensure-wasm-pack-installed.sh to do that? We should tag to a specific revision until the next versioned release.

@zamazan4ik
zamazan4ik requested review from a team February 17, 2023 00:36
@zamazan4ik

Copy link
Copy Markdown
Author

Is there a way to drop the already existing cache to test?

@github-actions

Copy link
Copy Markdown
Contributor

Regression Detector Results

Run ID: 617b7d87-641f-412f-a7f6-6ff36973e88e
Baseline: 6d43f48
Comparison: fc4d569
Total vector CPUs: 7

Explanation

A regression test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine quickly if vector performance is changed and to what degree by a pull request.

The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed.

Changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%:

experiment goal Δ mean Δ mean % confidence
datadog_agent_remap_datadog_logs ingress throughput 1.64MiB/CPU-s 5.11 100.00%
Fine details of change detection per experiment.
experiment goal Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
datadog_agent_remap_datadog_logs ingress throughput 1.64MiB/CPU-s 5.11 100.00% 32.08MiB/CPU-s 1.09MiB/CPU-s 14.37KiB/CPU-s 0.0 0.033904 33.72MiB/CPU-s 1.44MiB/CPU-s 18.99KiB/CPU-s 0.0 0.042645 False False
syslog_regex_logs2metric_ddmetrics ingress throughput 161.16KiB/CPU-s 4.55 100.00% 3.46MiB/CPU-s 418.48KiB/CPU-s 5.4KiB/CPU-s 0.0 0.11824 3.61MiB/CPU-s 373.24KiB/CPU-s 4.82KiB/CPU-s 0.0 0.100863 True False
syslog_loki ingress throughput 237.14KiB/CPU-s 2.71 100.00% 8.54MiB/CPU-s 273.5KiB/CPU-s 3.53KiB/CPU-s 0.0 0.031262 8.77MiB/CPU-s 201.47KiB/CPU-s 2.6KiB/CPU-s 0.0 0.02242 False False
otlp_http_to_blackhole ingress throughput 30.53KiB/CPU-s 2.01 100.00% 1.48MiB/CPU-s 126.82KiB/CPU-s 1.64KiB/CPU-s 0.0 0.083428 1.51MiB/CPU-s 122.89KiB/CPU-s 1.59KiB/CPU-s 0.0 0.079249 False False
datadog_agent_remap_datadog_logs_acks ingress throughput 584.47KiB/CPU-s 1.74 100.00% 32.75MiB/CPU-s 911.57KiB/CPU-s 11.76KiB/CPU-s 0.0 0.027176 33.33MiB/CPU-s 942.36KiB/CPU-s 12.16KiB/CPU-s 0.0 0.027613 False False
syslog_humio_logs ingress throughput 154.69KiB/CPU-s 1.70 100.00% 8.89MiB/CPU-s 213.98KiB/CPU-s 2.76KiB/CPU-s 0.0 0.023502 9.04MiB/CPU-s 409.12KiB/CPU-s 5.28KiB/CPU-s 0.0 0.044184 False False
syslog_splunk_hec_logs ingress throughput 129.04KiB/CPU-s 1.43 100.00% 8.8MiB/CPU-s 119.76KiB/CPU-s 1.55KiB/CPU-s 0.0 0.013293 8.92MiB/CPU-s 206.47KiB/CPU-s 2.66KiB/CPU-s 0.0 0.022595 False False
datadog_agent_remap_blackhole_acks ingress throughput 427.89KiB/CPU-s 1.37 100.00% 30.55MiB/CPU-s 1.85MiB/CPU-s 24.4KiB/CPU-s 0.0 0.060391 30.97MiB/CPU-s 1.22MiB/CPU-s 16.15KiB/CPU-s 0.0 0.039454 False False
splunk_hec_route_s3 ingress throughput 126.48KiB/CPU-s 1.08 100.00% 11.41MiB/CPU-s 591.71KiB/CPU-s 7.63KiB/CPU-s 0.0 0.050623 11.54MiB/CPU-s 536.92KiB/CPU-s 6.93KiB/CPU-s 0.0 0.045443 False False
http_to_http_acks ingress throughput 55.14KiB/CPU-s 1.02 71.33% 5.25MiB/CPU-s 2.75MiB/CPU-s 36.37KiB/CPU-s 0.0 0.523596 5.31MiB/CPU-s 2.79MiB/CPU-s 36.82KiB/CPU-s 0.0 0.524912 True False
http_to_http_json ingress throughput 80.49KiB/CPU-s 0.58 100.00% 13.54MiB/CPU-s 338.85KiB/CPU-s 4.37KiB/CPU-s 0.0 0.024431 13.62MiB/CPU-s 208.87KiB/CPU-s 2.69KiB/CPU-s 0.0 0.014972 False False
syslog_log2metric_splunk_hec_metrics ingress throughput 40.14KiB/CPU-s 0.43 100.00% 9.05MiB/CPU-s 352.64KiB/CPU-s 4.55KiB/CPU-s 0.0 0.03804 9.09MiB/CPU-s 286.8KiB/CPU-s 3.7KiB/CPU-s 0.0 0.030805 False False
splunk_hec_to_splunk_hec_logs_noack ingress throughput 9.18KiB/CPU-s 0.07 97.48% 13.62MiB/CPU-s 254.01KiB/CPU-s 3.28KiB/CPU-s 0.0 0.018216 13.63MiB/CPU-s 191.05KiB/CPU-s 2.47KiB/CPU-s 0.0 0.013692 False False
http_to_http_noack ingress throughput 4.19KiB/CPU-s 0.03 51.75% 13.61MiB/CPU-s 350.69KiB/CPU-s 4.52KiB/CPU-s 0.0 0.025161 13.61MiB/CPU-s 302.15KiB/CPU-s 3.9KiB/CPU-s 0.0 0.021672 False False
enterprise_http_to_http ingress throughput 2.06KiB/CPU-s 0.01 40.61% 13.62MiB/CPU-s 228.11KiB/CPU-s 2.94KiB/CPU-s 0.0 0.016354 13.62MiB/CPU-s 193.77KiB/CPU-s 2.5KiB/CPU-s 0.0 0.01389 False False
splunk_hec_indexer_ack_blackhole ingress throughput 605.98B/CPU-s 0.00 10.18% 13.62MiB/CPU-s 254.79KiB/CPU-s 3.29KiB/CPU-s 0.0 0.018272 13.62MiB/CPU-s 252.45KiB/CPU-s 3.26KiB/CPU-s 0.0 0.018103 False False
file_to_blackhole ingress throughput 1.68KiB/CPU-s 0.00 6.26% 54.49MiB/CPU-s 1.14MiB/CPU-s 15.12KiB/CPU-s 0.0 0.021006 54.49MiB/CPU-s 1.14MiB/CPU-s 15.09KiB/CPU-s 0.0 0.020983 False False
fluent_elasticsearch ingress throughput 129.6B/CPU-s 0.00 18.39% 45.41MiB/CPU-s 30.3KiB/CPU-s 395.8B/CPU-s 0.0 0.000652 45.41MiB/CPU-s 30.04KiB/CPU-s 392.33B/CPU-s 0.0 0.000646 False False
splunk_hec_to_splunk_hec_logs_acks ingress throughput -2.28KiB/CPU-s -0.02 26.77% 13.62MiB/CPU-s 361.58KiB/CPU-s 4.67KiB/CPU-s 0.0 0.025928 13.62MiB/CPU-s 369.84KiB/CPU-s 4.77KiB/CPU-s 0.0 0.026524 False False
datadog_agent_remap_blackhole ingress throughput -46.91KiB/CPU-s -0.15 94.11% 30.86MiB/CPU-s 1.32MiB/CPU-s 17.39KiB/CPU-s 0.0 0.042621 30.82MiB/CPU-s 1.34MiB/CPU-s 17.73KiB/CPU-s 0.0 0.043521 False False
otlp_grpc_to_blackhole ingress throughput -6.25KiB/CPU-s -0.60 100.00% 1.02MiB/CPU-s 37.87KiB/CPU-s 500.65B/CPU-s 0.0 0.036386 1.01MiB/CPU-s 51.95KiB/CPU-s 686.44B/CPU-s 0.0 0.050211 False False
socket_to_socket_blackhole ingress throughput -265.94KiB/CPU-s -1.99 100.00% 13.02MiB/CPU-s 259.93KiB/CPU-s 3.36KiB/CPU-s 0.0 0.019493 12.76MiB/CPU-s 364.3KiB/CPU-s 4.71KiB/CPU-s 0.0 0.027875 False False
http_text_to_http_json ingress throughput -519.9KiB/CPU-s -2.11 100.00% 24.09MiB/CPU-s 863.4KiB/CPU-s 11.15KiB/CPU-s 0.0 0.03499 23.59MiB/CPU-s 646.14KiB/CPU-s 8.34KiB/CPU-s 0.0 0.026749 False False
syslog_log2metric_humio_metrics ingress throughput -155.41KiB/CPU-s -2.47 100.00% 6.14MiB/CPU-s 279.8KiB/CPU-s 3.61KiB/CPU-s 0.0 0.044482 5.99MiB/CPU-s 238.47KiB/CPU-s 3.08KiB/CPU-s 0.0 0.038872 False False

@jszwedko

Copy link
Copy Markdown
Contributor

I dropped the cache and it looks good! Thanks for this contribution @zamazan4ik !

@jszwedko
jszwedko merged commit c8870af into vectordotdev:master Feb 21, 2023
@jszwedko

Copy link
Copy Markdown
Contributor

Merging since failed check was Netlify, but the subsequent build worked even though it didn't notify GHA of success.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: ci Anything related to Vector's CI environment domain: external docs Anything related to Vector's external, public documentation domain: vrl Anything related to the Vector Remap Language

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants