close
Skip to content

Tests for proposal-json-superset#1544

Merged
leobalter merged 3 commits into
tc39:masterfrom
gibson042:proposal-json-superset
May 8, 2018
Merged

Tests for proposal-json-superset#1544
leobalter merged 3 commits into
tc39:masterfrom
gibson042:proposal-json-superset

Conversation

@gibson042

Copy link
Copy Markdown
Member

tc39/proposal-json-superset#9

Allow non-ASCII LineTerminator characters (U+2028 LINE SEPARATOR and U+2029 PARAGRAPH SEPARATOR) in string literals.

@ljharb

ljharb commented May 7, 2018

Copy link
Copy Markdown
Member

Duplicate of #1543; is there anything here that could be added there?

@mathiasbynens

mathiasbynens commented May 8, 2018

Copy link
Copy Markdown
Member

I’m fine with either #1543 or this patch.

@mathiasbynens mathiasbynens left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

features.txt needs to be updated:

# ECMAScript ⊃ JSON
# https://github.com/tc39/proposal-json-superset
json-superset

And then the tests need the json-superset tag.

rwaldron
rwaldron previously approved these changes May 8, 2018
@rwaldron

rwaldron commented May 8, 2018

Copy link
Copy Markdown
Contributor

@gibson042 this is good to go with or without the update to features.txt and addition of json-superset (I can take care of it if you don't have time).

@leobalter

Copy link
Copy Markdown
Member

Bikeshedding some ideas to follow up in a new patch:

  • single quote strings
  • the .length property being affected by these characters
  • the .codePointAt returns
  • syntax being constructed through eval where a line separator is not allowed... e.g.: eval('async \u2029 function fn() {}') and eval('async \u2028 function fn() {}')

leobalter
leobalter previously approved these changes May 8, 2018
@gibson042
gibson042 dismissed stale reviews from leobalter and rwaldron via dbc0c6b May 8, 2018 18:19
@rwaldron

rwaldron commented May 8, 2018

Copy link
Copy Markdown
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants