fix(conn): properly inspect interfaces for nil values#838
Merged
Conversation
|
I have a similar issue. What's the best way to go since this PR has been open over a year? |
arp242
force-pushed
the
fix/nil-byte-interface
branch
from
January 3, 2026 14:18
aa6d63d to
d9270f9
Compare
arp242
force-pushed
the
fix/nil-byte-interface
branch
from
January 3, 2026 14:36
93193f0 to
22781f8
Compare
This was referenced Jan 4, 2026
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #773 by further inspecting arguments to check if they are nil interfaces or slices.
Sending a nil byte slice use to not work because it was a nil value of type
[]bytewhich!= nilhence it would really send an empty byte slice. This prevented you from setting columns to null unless you had a different path to send an explicit nil which also had no type(confusing and a pain to implement). Checking interface values equal nil is a common bug in go which usually requires using the reflect package to further inspect the interface's actual value is nil since the typing usually isn't.This does slightly slow down writes theoretically but it should be worth it for such a common use case and standard feature of sending nil.
Fixes #773