close
Skip to content

Thread author page params: Author.get_books #13539

Description

@RayBB

This is a good first issue. You don't need to wait to be assigned — just comment that you'd like to work on it, then open a PR referencing this issue.

Part of #13536. Read the epic first. It holds the main instructions.

Task

Remove hidden web.input() reads from the author page helper. Pass values as args. Keep behavior identical.

  • openlibrary/plugins/upstream/models.py:483 Author.get_books() — pass sort, page, rows, mode as args.
  • Update the caller in openlibrary/templates/type/author/view.html:23.

Done when

  • No web.input() inside get_books. Caller passes all 4 values.
  • No behavior change on author pages.
  • Existing tests pass (make test-py-uv). Do not add new tests.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Affects: DevelopersGood First IssueEasy issue. Good for newcomers. [managed]Lead: @RayBBIssues overseen by Ray (Onboarding & Documentation Lead) [manages]Needs: HelpIssues, typically substantial ones, that need a dedicated developer to take them on. [managed]Theme: DevelopmentIssues related to the developer experience and the dev environment. [managed]Type: Subtask of EpicA subtask that is part of the work breakdown of an epic issue (see comments). [managed]

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions