close
Skip to content

Show all DevTools pages in the sidebar#7947

Merged
kenzieschmoll merged 21 commits into
flutter:masterfrom
kenzieschmoll:sidebar-devtools
Jun 25, 2024
Merged

Show all DevTools pages in the sidebar#7947
kenzieschmoll merged 21 commits into
flutter:masterfrom
kenzieschmoll:sidebar-devtools

Conversation

@kenzieschmoll

@kenzieschmoll kenzieschmoll commented Jun 18, 2024

Copy link
Copy Markdown
Member

Work towards #7946.

Screenshot 2024-06-18 at 3 50 01 PM

This uses an adaptive layout so that the tools are condensed to a single column when the sidebar is very narrow. When no debug sessions are available, the DevTools tool is grayed out with a tooltip explaining why.
sidebar-no-debug-sessionsScreenshot 2024-06-21 at 1 32 21 PM

@kenzieschmoll
kenzieschmoll marked this pull request as ready for review June 21, 2024 20:27
@kenzieschmoll
kenzieschmoll requested a review from a team as a code owner June 21, 2024 20:27
@kenzieschmoll
kenzieschmoll requested review from CoderDake and removed request for a team June 21, 2024 20:27
@kenzieschmoll

Copy link
Copy Markdown
Member Author

@DanTup this is ready for review.

@DanTup DanTup left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DanTup DanTup left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still lgtm! (few very minor comments you're free to ignore)

Comment thread packages/devtools_app/lib/src/standalone_ui/vs_code/devtools_extensions.dart Outdated
Comment thread packages/devtools_app/test/standalone_ui/vs_code/devtools_test.dart
Comment thread packages/devtools_shared/lib/src/extensions/extension_manager.dart
@kenzieschmoll
kenzieschmoll merged commit e784023 into flutter:master Jun 25, 2024
@kenzieschmoll
kenzieschmoll deleted the sidebar-devtools branch June 25, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants