Remove Data Connect service deletion logic on deploy - #10619
Merged
Conversation
### Description Removes the prompt and backend deletion of Data Connect services during `firebase deploy`. It is a common and well-intended usecase to have multiple Data Connect repositories sharing the same Firebase project. Without removing this prompt and deletion behavior, deploying from one repository would attempt to delete the services of the other, or prompt the user unexpectedly. ### Scenarios Tested - Unit tests in `deploy.spec.ts` updated and run: - `npx mocha src/deploy/dataconnect/deploy.spec.ts` ### Sample Commands - `firebase deploy --only dataconnect`
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the prompt and logic to delete Data Connect services not listed in firebase.json during deployment, along with their associated unit tests. The reviewer suggests cleaning up the unused numServiceDeleted property from the DeployStats interface and context to avoid maintaining dead code and reporting redundant telemetry metrics.
| const servicesToDelete = filters | ||
| ? [] | ||
| : services.filter((s) => !serviceInfos.some((si) => matches(si, s))); | ||
| dataconnect.deployStats.numServiceDeleted = servicesToDelete.length; |
Contributor
There was a problem hiding this comment.
With the removal of the service deletion logic, dataconnect.deployStats.numServiceDeleted is no longer set and will always default to 0. To avoid maintaining dead code and reporting redundant telemetry metrics, please also clean up numServiceDeleted from the DeployStats interface and deployStatsParams in src/deploy/dataconnect/context.ts.
### Description Removes `numServiceDeleted` from the `DeployStats` interface and telemetry params (`deployStatsParams`) in `src/deploy/dataconnect/context.ts` to avoid reporting redundant telemetry metrics. ### Scenarios Tested - Run tests: `npx mocha src/deploy/dataconnect/deploy.spec.ts` - Ran build: `npm run build`
joehan
approved these changes
Jun 10, 2026
mtr002
pushed a commit
that referenced
this pull request
Jun 10, 2026
* feat: remove Data Connect service deletion prompt on deploy ### Description Removes the prompt and backend deletion of Data Connect services during `firebase deploy`. It is a common and well-intended usecase to have multiple Data Connect repositories sharing the same Firebase project. Without removing this prompt and deletion behavior, deploying from one repository would attempt to delete the services of the other, or prompt the user unexpectedly. ### Scenarios Tested - Unit tests in `deploy.spec.ts` updated and run: - `npx mocha src/deploy/dataconnect/deploy.spec.ts` ### Sample Commands - `firebase deploy --only dataconnect` * no need for changelog * refactor: clean up numServiceDeleted telemetry metric from DeployStats ### Description Removes `numServiceDeleted` from the `DeployStats` interface and telemetry params (`deployStatsParams`) in `src/deploy/dataconnect/context.ts` to avoid reporting redundant telemetry metrics. ### Scenarios Tested - Run tests: `npx mocha src/deploy/dataconnect/deploy.spec.ts` - Ran build: `npm run build`
fredzqm
added a commit
that referenced
this pull request
Jun 10, 2026
bkendall
pushed a commit
that referenced
this pull request
Jul 9, 2026
* feat: remove Data Connect service deletion prompt on deploy ### Description Removes the prompt and backend deletion of Data Connect services during `firebase deploy`. It is a common and well-intended usecase to have multiple Data Connect repositories sharing the same Firebase project. Without removing this prompt and deletion behavior, deploying from one repository would attempt to delete the services of the other, or prompt the user unexpectedly. ### Scenarios Tested - Unit tests in `deploy.spec.ts` updated and run: - `npx mocha src/deploy/dataconnect/deploy.spec.ts` ### Sample Commands - `firebase deploy --only dataconnect` * no need for changelog * refactor: clean up numServiceDeleted telemetry metric from DeployStats ### Description Removes `numServiceDeleted` from the `DeployStats` interface and telemetry params (`deployStatsParams`) in `src/deploy/dataconnect/context.ts` to avoid reporting redundant telemetry metrics. ### Scenarios Tested - Run tests: `npx mocha src/deploy/dataconnect/deploy.spec.ts` - Ran build: `npm run build`
bkendall
pushed a commit
that referenced
this pull request
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the prompt and backend deletion of Data Connect services during
firebase deploy. It is a common and well-intended usecase to have multiple Data Connect repositories sharing the same Firebase project. Without removing this prompt and deletion behavior, deploying from one repository would attempt to delete the services of the other, or prompt the user unexpectedly.We don't really have good support to track >1 FDC services in the same local folder, making it very difficult to address this prompt in a proper way.
Scenarios Tested
deploy.spec.tsupdated and run:npx mocha src/deploy/dataconnect/deploy.spec.tsSample Commands
firebase deploy --only dataconnectDescription
Scenarios Tested
Sample Commands