close
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,32 +5,32 @@

let commandScopes = new Set<string>();

export const authProxyOrigin = () =>

Check warning on line 8 in src/api.ts

View workflow job for this annotation

Image GitHub Actions / lint (20)

Missing return type on function
utils.envOverride("FIREBASE_AUTHPROXY_URL", "https://auth.firebase.tools");
// "In this context, the client secret is obviously not treated as a secret"
// https://developers.google.com/identity/protocols/OAuth2InstalledApp
export const clientId = () =>

Check warning on line 12 in src/api.ts

View workflow job for this annotation

Image GitHub Actions / lint (20)

Missing return type on function
utils.envOverride(
"FIREBASE_CLIENT_ID",
"563584335869-fgrhgmd47bqnekij5i8b5pr03ho849e6.apps.googleusercontent.com",
);
export const clientSecret = () =>

Check warning on line 17 in src/api.ts

View workflow job for this annotation

Image GitHub Actions / lint (20)

Missing return type on function
utils.envOverride("FIREBASE_CLIENT_SECRET", "j9iVZfS8kkCEFUPaAeJV0sAi");
export const cloudbillingOrigin = () =>

Check warning on line 19 in src/api.ts

View workflow job for this annotation

Image GitHub Actions / lint (20)

Missing return type on function
utils.envOverride("FIREBASE_CLOUDBILLING_URL", "https://cloudbilling.googleapis.com");
export const cloudloggingOrigin = () =>

Check warning on line 21 in src/api.ts

View workflow job for this annotation

Image GitHub Actions / lint (20)

Missing return type on function
utils.envOverride("FIREBASE_CLOUDLOGGING_URL", "https://logging.googleapis.com");
export const cloudMonitoringOrigin = () =>

Check warning on line 23 in src/api.ts

View workflow job for this annotation

Image GitHub Actions / lint (20)

Missing return type on function
utils.envOverride("CLOUD_MONITORING_URL", "https://monitoring.googleapis.com");
export const containerRegistryDomain = () =>

Check warning on line 25 in src/api.ts

View workflow job for this annotation

Image GitHub Actions / lint (20)

Missing return type on function
utils.envOverride("CONTAINER_REGISTRY_DOMAIN", "gcr.io");

export const developerConnectOrigin = () =>

Check warning on line 28 in src/api.ts

View workflow job for this annotation

Image GitHub Actions / lint (20)

Missing return type on function
utils.envOverride("DEVELOPERCONNECT_URL", "https://developerconnect.googleapis.com");
export const developerConnectP4SADomain = () =>

Check warning on line 30 in src/api.ts

View workflow job for this annotation

Image GitHub Actions / lint (20)

Missing return type on function
utils.envOverride("DEVELOPERCONNECT_P4SA_DOMAIN", "gcp-sa-devconnect.iam.gserviceaccount.com");

export const artifactRegistryDomain = () =>

Check warning on line 33 in src/api.ts

View workflow job for this annotation

Image GitHub Actions / lint (20)

Missing return type on function
utils.envOverride("ARTIFACT_REGISTRY_DOMAIN", "https://artifactregistry.googleapis.com");
export const appDistributionOrigin = () =>
utils.envOverride(
Expand All @@ -56,10 +56,6 @@
utils.envOverride("FIREBASE_AUTH_MANAGEMENT_URL", "https://identitytoolkit.googleapis.com");
export const consoleOrigin = () =>
utils.envOverride("FIREBASE_CONSOLE_URL", "https://console.firebase.google.com");
export const dynamicLinksOrigin = () =>
utils.envOverride("FIREBASE_DYNAMIC_LINKS_URL", "https://firebasedynamiclinks.googleapis.com");
export const dynamicLinksKey = () =>
utils.envOverride("FIREBASE_DYNAMIC_LINKS_KEY", "AIzaSyB6PtY5vuiSB8MNgt20mQffkOlunZnHYiQ");
export const eventarcOrigin = () =>
utils.envOverride("EVENTARC_URL", "https://eventarc.googleapis.com");
export const firebaseApiOrigin = () =>
Expand Down
2 changes: 0 additions & 2 deletions src/commands/ext-dev-usage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import { getPublisherProjectFromName, logPrefix } from "../extensions/extensions
import { FirebaseError, getErrMsg, getError } from "../error";
import { logger } from "../logger";
import { select } from "../prompt";
import { shortenUrl } from "../shortenUrl";

export const command = new Command("ext:dev:usage <publisherId>")
.description("get usage statistics for an extension")
Expand Down Expand Up @@ -168,6 +167,5 @@ async function buildCloudMonitoringLink(args: {
`https://console.cloud.google.com/monitoring/metrics-explorer?project=${args.projectNumber}` +
`&pageState=${JSON.stringify(pageState)}`;
uri = encodeURI(uri);
uri = await shortenUrl(uri);
return uri;
}
6 changes: 1 addition & 5 deletions src/emulator/extensionsEmulator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import { FirebaseError } from "../error";
import { getExtensionFunctionInfo } from "../extensions/emulator/optionsHelper";
import { toExtensionVersionRef } from "../extensions/refs";
import { Options } from "../options";
import { shortenUrl } from "../shortenUrl";
import { Constants } from "./constants";
import { downloadExtensionVersion } from "./download";
import { EmulatorLogger } from "./emulatorLogger";
Expand Down Expand Up @@ -320,10 +319,7 @@ export class ExtensionsEmulator implements EmulatorInstance {
style: { head: ["yellow"] },
});
for (const apiToWarn of apisToWarn) {
// We use a shortened link here instead of a alias because cli-table behaves poorly with aliased links
const enablementUri = await shortenUrl(
enableApiURI(this.args.projectId, apiToWarn.apiName),
);
const enablementUri = enableApiURI(this.args.projectId, apiToWarn.apiName);
table.push([
apiToWarn.apiName,
apiToWarn.instanceIds.join(", "),
Expand Down
38 changes: 0 additions & 38 deletions src/shortenUrl.spec.ts

This file was deleted.

51 changes: 0 additions & 51 deletions src/shortenUrl.ts

This file was deleted.

Loading