close
Skip to content

A bunch of backwards-compatible cleanup #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nedtwigg merged 19 commits into from
Jun 3, 2020
Merged

A bunch of backwards-compatible cleanup #592

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
f4d9e1c
Fix javadoc problems.
nedtwigg Jun 3, 2020
f0b3599
Rename FormatExtension's field SpotlessExtension from `ext` to `spotl…
nedtwigg Jun 3, 2020
9555cf0
Rename GradleIntegrationTest to GradleIntegrationHarness (every *Test…
nedtwigg Jun 3, 2020
0ef497f
Rename MavenIntegrationTest to MavenIntegrationHarness (every *Test s…
nedtwigg Jun 3, 2020
160cf3c
Add Test suffix to ErrorShouldRethrow since they are tests.
nedtwigg Jun 3, 2020
d9dd10f
Remove deprecated (and unused) ExpectedException.
nedtwigg Jun 3, 2020
ee5b6fa
Fix @SuppressWarnings tag in the wrong place for GoogleJavaFormat.
nedtwigg Jun 3, 2020
e7941fe
Replace deprecated hamcrest stuff with assertj.
nedtwigg Jun 3, 2020
3ea4f86
Deprecate GradleProvisioner.fromProject() with a faster implementatio…
nedtwigg Jun 3, 2020
f6f6147
Rename SpotlessPluginLegacy to indicate that it is only related to co…
nedtwigg Jun 3, 2020
6d1c188
Update our plugins tags to accurately represent the formatters we sup…
nedtwigg Jun 2, 2020
359ee60
Improve padded cell's deprecation message.
nedtwigg Jun 3, 2020
fffc555
Fail the build if javadoc gets broken.
nedtwigg Jun 3, 2020
2d7d8cb
Improve plugin-gradle build, using lessons from https://github.com/di…
nedtwigg Jun 3, 2020
7fe5726
Rework gitRatchet so that we can deprecate SpotlessPlugin.getExtensio…
nedtwigg Jun 3, 2020
bbb0e47
Centralize all platform-checking code and platform-native path handli…
nedtwigg Jun 3, 2020
a41ce87
Move native path handling code to FileSignature, since it's the close…
nedtwigg Jun 3, 2020
bfd2325
Update changelogs.
nedtwigg Jun 3, 2020
8b44556
Fix some maven formatting.
nedtwigg Jun 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fail the build if javadoc gets broken.
  • Loading branch information
@nedtwigg
nedtwigg committed Jun 3, 2020
commit fffc555be69e198cfbe89ad27e9ed2132d42b810
1 change: 1 addition & 0 deletions gradle/java-publish.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ task sourcesJar(type: Jar) {
// Thus, no javadoc warnings.
javadoc {
options.addStringOption('Xdoclint:none', '-quiet')
options.addStringOption('Xwerror', '-quiet')
enabled = org.gradle.api.JavaVersion.current() == org.gradle.api.JavaVersion.VERSION_1_8
}

Expand Down
4 changes: 2 additions & 2 deletions plugin-gradle/src/main/java/com/diffplug/gradle/spotless/FormatExtension.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,8 +452,8 @@ public LicenseHeaderConfig yearSeparator(String yearSeparator) {
* Will turn `2004` into `2004-2020`, and `2004-2019` into `2004-2020`
* Default value is false, unless {@link SpotlessExtension#ratchetFrom(String)} is used, in which case default value is true.
*/
public LicenseHeaderConfig updateYearWithLatest(boolean overwriteYearLatest) {
this.updateYearWithLatest = overwriteYearLatest;
public LicenseHeaderConfig updateYearWithLatest(boolean updateYearWithLatest) {
this.updateYearWithLatest = updateYearWithLatest;
replaceStep(createStep());
return this;
}
Expand Down
1 change: 1 addition & 0 deletions testlib/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,5 @@ task npmTest(type: Test) { useJUnit { includeCategories 'com.diffplug.spotless.c

javadoc {
options.addStringOption('Xdoclint:none', '-quiet')
options.addStringOption('Xwerror', '-quiet')
}