fix the e2e retry logic

[vicb]

While working on #11397, I notice that the retry logic was wrong:

• failed tests are always emptied at the end of the outer for loop so the script would never exit with a non 0 status code
• "retrying ..." would be displayed even after the last iteration (no more retry)

---

• Tests
  • Tests included
  • Tests not necessary because: tested on the mentioned PR
• Public documentation
  • Cloudflare docs PR(s):
  • Documentation not necessary because: ci
• Wrangler V3 Backport
  • Wrangler PR: fix the e2e retry logic #11400
  • Not necessary because:

[changeset-bot]

⚠️ No Changeset found

Latest commit: bd52f3e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[pkg-pr-new]

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11399

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11399

miniflare

npm i https://pkg.pr.new/miniflare@11399

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11399

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11399

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11399

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11399

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11399

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@11399

wrangler

npm i https://pkg.pr.new/wrangler@11399

commit: bd52f3e