Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove `ssl_version` option from webhook #949
Merged
Conversation
Due to the SSLv3 POODLE issue, anyone who has SSLv3 set manually on their webhook won't be able to communicate with their servers. This especially impacts anyone who uses something like Heroku to host their integration. Given SSLv3 is insecure regardless, I think it's best to completely remove this option. The documentation also stated that you could set to SSLv2 but that isn't actually true in the code below. cc @jdpace @dbussink
|
|
|
We also checked all webhooks that currently specify the |
kdaigle
added a commit
that referenced
this pull request
Oct 16, 2014
Remove `ssl_version` option from webhook
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kdaigle commentedOct 16, 2014
Due to the SSLv3 POODLE issue, anyone who has SSLv3 set manually on their webhook won't be able to communicate with servers who (likely) dropped support for SSLv3. This also impacts anyone who uses something like Heroku to host their integration. Given SSLv3 is insecure regardless, I think it's best to completely remove this option.
The documentation also stated that you could set to SSLv2 but that isn't actually true in the code below. This clarifies and relies on TLS.
cc @jdpace @dbussink