close
The Wayback Machine - https://web.archive.org/web/20201119142725/https://github.com/GoogleChrome/devtools-docs/pull/20
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emulation doc update #15 #20

Merged
merged 4 commits into from Dec 2, 2013

Conversation

@umaar
Copy link
Member

@umaar umaar commented Dec 1, 2013

Please review.

It seems most the content was still valid and made sense, just a few things needed updating.

@paulirish
Copy link
Member

@paulirish paulirish commented Dec 2, 2013

You currently need to turn on emulation panel in settings. In Canary it's now in General settings. Call this out.

Also can you indicate this was previously called Overrides so people googling for that can find the new location?

@paulirish
Copy link
Member

@paulirish paulirish commented Dec 2, 2013

Currently, setting device metrics will not emulate the behavior specified in a tag or (@Viewport { … } rule). You can run Chrome with additional flags to emulate mobile viewport behavior: …

thats no longer true.

i'd love to show a before/after to really demonstrate the viewport emulation in action.

@paulirish
Copy link
Member

@paulirish paulirish commented Dec 2, 2013

Let's move emulating devices above the touch events tuff.

We need a screenshot of emulation in action.. full window.

I'd be down for an animgif with shift-drag pinchzoom and also scroll to see the content go in and out of viewport

@paulirish
Copy link
Member

@paulirish paulirish commented Dec 2, 2013

Awesome updates. Love the images in here.

Later I'd like to add additional details into the docs but this is a great start for us.

Thanks!

@paulirish
Copy link
Member

@paulirish paulirish commented Dec 2, 2013

I know it's too late for tonight but can I get your help with these tomorrow morning?

cc @addyosmani

@addyosmani
Copy link
Member

@addyosmani addyosmani commented Dec 2, 2013

@umaar thanks for the updates! Will you have time to address the comments this afternoon?

@umaar
Copy link
Member Author

@umaar umaar commented Dec 2, 2013

Thanks for the review Paul. @addyosmani and Paul, I know the hope was to get this all completed in time for the meeting, but I'm at work now and can only look at this afterwards. I can address the comments before the end of today.

@paulirish
Copy link
Member

@paulirish paulirish commented Dec 2, 2013

Cool no problem. Sounds good!

@paulirish
Copy link
Member

@paulirish paulirish commented Dec 2, 2013

Hey umar, can you just ping me on IM when you drop these in? i'm gonna act fast. :D

@umaar
Copy link
Member Author

@umaar umaar commented Dec 2, 2013

Hey, yeah I'll let you know on IM.

@umaar
Copy link
Member Author

@umaar umaar commented Dec 2, 2013

  • explain how to turn on emulation panel in settings
    • also indicate this was previously called Overrides
  • Currently, setting device metrics will not emulate the behavior
    • remove this bit as it's not true anymore.
  • move emulating devices above the touch events
  • animated gif with pinchzoom.
    • this is in lieu of full-window screenshot, the gif is full-window
  • before/after to really demonstrate the viewport emulation in action
    • trying to find a good example of this. Are there any you can think of?

Please review the updated changes & let me know if you have anything else in mind.

@paulirish
Copy link
Member

@paulirish paulirish commented Dec 2, 2013

how about animgif of clicking in/out of a few of these: http://andreasbovens.github.io/understanding-viewport/

@umaar
Copy link
Member Author

@umaar umaar commented Dec 2, 2013

Have given it a go - animated gif showing viewport emulation.

@paulirish
Copy link
Member

@paulirish paulirish commented Dec 2, 2013

LGTM

thank you!

paulirish added a commit that referenced this pull request Dec 2, 2013
@paulirish paulirish merged commit 85ee9cf into GoogleChrome:master Dec 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.