This repository was archived by the owner on Sep 4, 2019. It is now read-only.
ws@1.1.0 breaks build 🚨#36
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello 👋
🚨🚨🚨
ws just published its new version 1.1.0, which is covered by your current version range. After updating it in your project the build went from success to failure.
This means your software is now malfunctioning, because of this update. Use this branch to work on adaptions and fixes.
Happy fixing and merging 🌴
The new version differs by 38 commits .
4263f26[dist] 1.1.024625acMerge pull request #336 from MosNicholas/nmos_server_crash_fixe62cf35Merge pull request #636 from SEAPUNK/patch-1a7ea2b1Merge pull request #653 from JacksonTian/coverage4f99812Merge pull request #569 from cybusio/master0669caeMerge pull request #688 from agilethomas/hixie76_haproxy872bbbdMerge pull request #654 from JacksonTian/concatffed6efMerge pull request #605 from sebpiq/master0d1fb9cMerge pull request #706 from misobytes/emitCloseEventOnConnectionFailurefc0d15bemit both an error and close event when connection establishment fails1242a8cMerge pull request #681 from LordMajestros/master8490213Merge pull request #698 from rib/binarytypedd9611eMerge pull request #703 from StreamMeDev/close-doc-updatec3c6554added documentation for close callbackb80b335lib/WebSocket.js: expose binaryType propertyThere are 38 commits in total. See the full diff.