This repository was archived by the owner on Sep 4, 2019. It is now read-only.
feathers-commons@0.8.7 breaks build 🚨#122
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello lovely humans,
feathers-commons just published its new version 0.8.7.
This version is covered by your current version range and after updating it in your project the build went from success to failure.
As feathers-commons is a direct dependency of this project this is very likely breaking your project right now. If other packages depend on you it’s very likely also breaking them.
I recommend you give this issue a very high priority. I’m sure you can resolve this 💪
Of course this could just be a false positive, caused by a flaky test suite, or third parties that are currently broken or unavailable, but that would be another problem I’d recommend working on.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Good luck with your project ✨
You rock!
🌴
The new version differs by 29 commits .
4cf0aa10.8.7b083495Merge pull request #47 from feathersjs/matcher-null-fix2b9c727matcher now doesn't blow up with null values. Closes #468e6b856Updating changelog166bbf70.8.64e104c1Allow to pass an object to hook object (#45)4196fe70.8.51c90914Merge pull request #44 from feathersjs/mergeeebca27adding merge and isObject functions9843d98Merge pull request #43 from feathersjs/expose-lodash-functions8ebfaa6exposing lodash style functions top level as well6ecc830Merge pull request #42 from feathersjs/make-urlb31f533Merge pull request #41 from feathersjs/expect-syntax8382f47ensuring makeUrl works with an actual feathers app insance.09fa1f8converting over other filesThere are 29 commits in total. See the full diff.