This repository was archived by the owner on Sep 4, 2019. It is now read-only.
Update feathers-socketio to version 1.4.2 🚀#109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello lovely humans,
feathers-socketio just published its new version 1.4.2.
This version is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of feathers-socketio.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Good luck with your project ✨
You rock!
🌴
The new version differs by 19 commits .
2a3c2df1.4.2d11dc54Bumping socket.io versionc677f99chore: drop support for Node.js 0.10 (#48)5517c32Adding supported node versions to Travis file, coverage folder to .npmignore, Slack badge to README and Slack notifications to Travis filea4cfd48Merge pull request #47 from feathersjs/windows-support966242eSwapping rm to rifraf and using relative path to _mocha for windows supporte718eafFixing .npmignore for .github folderb8a1b76Adding .github to .npmignoreb6e13f2Adding .github folder and templates5cf6e0aMerge pull request #46 from feathersjs/semistandard1b5e479jshint —> semistandard417f493Use proper client for code coverage0e81112Merge pull request #45 from feathersjs/bump-feathers418552dupdate feathers dev dependency248a7dbMerge pull request #44 from feathersjs/code-coverageThere are 19 commits in total. See the full diff.